Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls: permit null as a pfx value #41170

Merged
merged 2 commits into from
Dec 27, 2021
Merged

tls: permit null as a pfx value #41170

merged 2 commits into from
Dec 27, 2021

Commits on Dec 15, 2021

  1. tls: permit null as a pfx value 

    Allow null along with undefined for pfx value.

This is to avoid breaking change when upgrading v14 to v16 and
3rd party library passing null to pfx

Fixes: nodejs#36292
    @CallMeLaNN
    CallMeLaNN committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    8fd11f9 View commit details
    Browse the repository at this point in the history

  2. tls: permit null as an options value 

    Allow the expected null along with undefined for options value.

This is to avoid breaking change when upgrading v14 to v16 and
3rd party library passing null to options

Fixes: nodejs#36292
    @CallMeLaNN
    CallMeLaNN committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    f474aa5 View commit details
    Browse the repository at this point in the history