doc: include stack trace difference in ES modules #41157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
thebergamo
changed the title
thebergamo
changed the title
aduh95
reviewed
Dec 13, 2021
This change highlights in the docs difference between stack traces for CommonJS modules and ES Modules. Fixes: nodejs#39787
|
I wasn't sure which commit message I should use in case of accepting those changes you proposed @aduh95 so I just made them in my code and pushed. |
mscdex
changed the title
|
/cc @nodejs/modules |
jasnell
approved these changes
Dec 17, 2021
aduh95
added
author ready
jasnell
pushed a commit
that referenced
this pull request
Dec 24, 2021
This change highlights in the docs difference between stack traces for CommonJS modules and ES Modules. Fixes: #39787 PR-URL: #41157 Reviewed-By: James M Snell <[email protected]>
|
Landed in 1e34969 |
targos
pushed a commit
that referenced
this pull request
Jan 14, 2022
This change highlights in the docs difference between stack traces for CommonJS modules and ES Modules. Fixes: #39787 PR-URL: #41157 Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
This change highlights in the docs difference between stack traces for CommonJS modules and ES Modules. Fixes: #39787 PR-URL: #41157 Reviewed-By: James M Snell <[email protected]>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
This change highlights in the docs difference between stack traces for CommonJS modules and ES Modules. Fixes: nodejs#39787 PR-URL: nodejs#41157 Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
This change highlights in the docs difference between stack traces for CommonJS modules and ES Modules. Fixes: #39787 PR-URL: #41157 Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change highlihts in the docs difference between stack traces for CJS modules and ES Modules.
Fixes: #39787