stream: manual destroy ServerResponse on pipeline

[RafaelGSS]

Change the behavior to not destroy the ServerResponse stream on stream.pipeline when
an error happens.

Address: #26311

---

I feel that #38262 was a similar issue that was solved differently, however, I do not find a better way to solve it so far. I'm completely open to changing the current approach to a non-breaking one.

[ronag]

I think you mean ServerResponse which is not an IncomingMessage.

[ronag]

I'm not sure I agree with this. The pattern in #26311 is not something I'd recommend.

[ronag]

I think it's better to add an option to pipeline to not destroy the last stream.

[RafaelGSS]

I think it's better to add an option to pipeline to not destroy the last stream.

It's not exactly what #34133 was doing?

[ronag]

You are changing the behavior of server response instead of making it an explicit option on pipeline.

[RafaelGSS]

You are changing the behavior of server response instead of making it an explicit option on pipeline.

@ronag I don't know if I get it. I mean, the #34133 was created to solve the same issue using the "explicit option" approach, however, the feature was considered not needed (sorry if I'm missing something).

This PR uses a different approach to solve the same issue avoiding an explicit option adding more complexity to the end-user, but looks not acceptable either (and I completely understand your point of view).

In this case, shall we re-open the other PR and close this one?

[RafaelGSS]

If none of those options are available, perhaps a note in the documentation noticing those edge cases using ServerResponse inside pipeline would be necessary, what do you think?

[RafaelGSS]

Hey @ronag, friendly ping. Maybe should we update the documentation by adding this edge case?

[ronag]

I'm not quite sure what edge cases you are referring to but adding documentations is usually a good idea. I'm not entirely up to speed here anymore.

[RafaelGSS]

Closing in favor of #41796