doc: move style guide to findable location #41119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
force-pushed
the
move-style-guide
branch
from
a8cd2dc to
b6b8ab0
Compare
targos
approved these changes
Dec 9, 2021
This comment has been minimized.
This comment has been minimized.
targos
reviewed
Dec 9, 2021
Closed
Move the style guide to doc/README.md so people might find it. The current location is easily overlooked, as is evidenced by nodejs#41025
Trott
force-pushed
the
move-style-guide
branch
from
b6b8ab0 to
30afd3a
Compare
DerekNonGeneric
approved these changes
Dec 9, 2021
DerekNonGeneric
added
the
author ready
VoltrexKeyva
approved these changes
Dec 9, 2021
DerekNonGeneric
added
the
fast-track
|
Fast-track has been requested by @DerekNonGeneric. Please 👍 to approve. |
jasnell
approved these changes
Dec 10, 2021
DerekNonGeneric
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 42dd3ca |
danielleadams
pushed a commit
that referenced
this pull request
Dec 13, 2021
Move the style guide to doc/README.md so people might find it. The current location is easily overlooked, as is evidenced by #41025 PR-URL: #41119 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Dec 14, 2021
Move the style guide to doc/README.md so people might find it. The current location is easily overlooked, as is evidenced by #41025 PR-URL: #41119 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
Move the style guide to doc/README.md so people might find it. The current location is easily overlooked, as is evidenced by #41025 PR-URL: #41119 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
Move the style guide to doc/README.md so people might find it. The current location is easily overlooked, as is evidenced by #41025 PR-URL: #41119 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: James M Snell <[email protected]>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
Move the style guide to doc/README.md so people might find it. The current location is easily overlooked, as is evidenced by nodejs#41025 PR-URL: nodejs#41119 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
Move the style guide to doc/README.md so people might find it. The current location is easily overlooked, as is evidenced by #41025 PR-URL: #41119 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
technic960183
added a commit
to technic960183/node
that referenced
this pull request
Dec 8, 2024
The link to the style guide in `pull-requests.md` linked to the main `README.md` instead of `doc/README.md`. This commit fixes the link. Refs: nodejs#41119
nodejs-github-bot
pushed a commit
that referenced
this pull request
Dec 10, 2024
The link to the style guide in `pull-requests.md` linked to the main `README.md` instead of `doc/README.md`. This commit fixes the link. Refs: #41119 PR-URL: #56181 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Dec 10, 2024
The link to the style guide in `pull-requests.md` linked to the main `README.md` instead of `doc/README.md`. This commit fixes the link. Refs: #41119 PR-URL: #56181 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the style guide to doc/README.md so people might find it. The
current location is easily overlooked, as is evidenced by
#41025