Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: cleanup eos #40998

Merged
merged 1 commit into from
Dec 1, 2021
Merged

stream: cleanup eos #40998

merged 1 commit into from
Dec 1, 2021

Conversation

ronag
Copy link
Member

@ronag ronag commented Nov 28, 2021 •
edited
Loading

Improve readability

@ronag
Copy link
Member Author

ronag commented Nov 28, 2021

@nodejs/streams

@ronag ronag added the stream Issues and PRs related to the stream subsystem. label Nov 28, 2021
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 28, 2021
@ronag ronag added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Nov 28, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 28, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
BridgeAR
BridgeAR approved these changes Nov 28, 2021
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ronag ronag added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 28, 2021
lpinca
lpinca approved these changes Nov 28, 2021
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a comment. It shouldn't cause issues in practice but ¯_(ツ)_/¯

lib/internal/streams/end-of-stream.js
(options.readable !== false && isReadableNodeStream(stream));
const writable = options.writable ||
(options.writable !== false && isWritableNodeStream(stream));
const readable = options.readable ?? isReadableNodeStream(stream);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Behavior is different for some falsy values.

mcollina
mcollina approved these changes Nov 28, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions bot mentioned this pull request Nov 29, 2021
Open
27 tasks
@ronag ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41216/

@BridgeAR BridgeAR added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 1, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 1, 2021
@nodejs-github-bot nodejs-github-bot merged commit 40a52bd into nodejs:master Dec 1, 2021
@nodejs-github-bot
Copy link
Collaborator

Landed in 40a52bd

@github-actions github-actions bot mentioned this pull request Dec 3, 2021
Open
36 tasks
danielleadams pushed a commit that referenced this pull request Dec 13, 2021
@ronag @danielleadams
stream: cleanup eos
4f03cd4 
PR-URL: #40998
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 14, 2021
@ronag @danielleadams
stream: cleanup eos
513305c 
PR-URL: #40998
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 14, 2021
Merged
@danielleadams
Copy link
Contributor

@ronag do you mind opening a backport PR for this to v16.x-staging? When pulling it for the release, it causes some failing tests.

Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@ronag @Linkgoron
stream: cleanup eos
9ea30b8 
PR-URL: nodejs#40998
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

@jasnell jasnell jasnell approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@ronag @nodejs-github-bot @danielleadams @mcollina @jasnell @benjamingr @lpinca @BridgeAR @targos