util: make inspect more reliable #4098
Conversation
|
LGTM if the CI is happy. |
|
LGTM |
|
Will land tomorrow if there are no objections. Thanks! |
|
LGTM |
34a3591 added pretty printing for TypedArray, ArrayBuffer, and DataView. This change allows inspecting those across different contexts. Since instanceof does not work across contexts, we can use v8::Value::IsTypedArray, v8::Value::IsArrayBuffer, and v8::Value::IsDataView PR-URL: nodejs#4098 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
evanlucas
force-pushed
the
utiltypedarray
branch
from
2748af1
to
24012a8
Compare
|
landed in 24012a8. Thanks! |
|
I'm going to add semver-major because its dependency, 34a3591 / #3793, is tagged as semver-major and we need to keep them both off v5.x, I'm also going to remove lts-watch-v4.x. I'm not convinced that 34a3591 should be semver-major but that's a discussion for #3793. /cc @bnoordhuis |
rvagg
added
semver-major
|
Note on semver-major: I think a case could be made that this is semver-major on its own, but I'd really just like the clarity that this is tied to another semver-major and therefore needs to stay out of backports, we could possibly remove the tag before pushing 6.0.0 out if we want to keep that out of the release notes. Perhaps another label would be helpful for these semver edge-cases? Same applies to the |
34a3591 added pretty printing for TypedArray, ArrayBuffer, and DataView. This change allows inspecting those across different contexts. Since instanceof does not work across contexts, we can use v8::Value::IsTypedArray, v8::Value::IsArrayBuffer, and v8::Value::IsDataView PR-URL: nodejs#4098 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
34a3591 added pretty printing for
TypedArray, ArrayBuffer, and DataView. This change allows inspecting
those across different contexts.
Since instanceof does not work across contexts, we can use
v8::Value::IsTypedArray, v8::Value::IsArrayBuffer, and
v8::Value::IsDataView
/cc @bnoordhuis