v16.13.1 proposal

.eslintrc.js

@@ -17,6 +17,7 @@ const hacks = [
   'eslint-plugin-node-core',
   'eslint-plugin-markdown',
   '@babel/eslint-parser',
+  '@babel/plugin-syntax-import-assertions',
 ];
 Module._findPath = (request, paths, isMain) => {
   const r = ModuleFindPath(request, paths, isMain);
@@ -36,6 +37,11 @@ module.exports = {
   plugins: ['markdown', 'node-core'],
   parser: '@babel/eslint-parser',
   parserOptions: {
+    babelOptions: {
+      plugins: [
+        Module._findPath('@babel/plugin-syntax-import-assertions'),
+      ],
+    },
     requireConfigFile: false,
     sourceType: 'script',
   },

.github/ISSUE_TEMPLATE/4-report-a-flaky-test.yml

@@ -0,0 +1,47 @@
+name: Report a flaky test
+description: Report a flaky test in our CI
+title: "Investigate flaky test - "
+labels: ["flaky-test"]
+body:
+  - type: markdown
+    attributes:
+      value: |
+        Thank you for reporting a flaky test.
+
+        Flaky tests are tests that fail occasionally in the Node.js CI, but not
+        consistently enough to block PRs from landing, or that are failing in CI
+        jobs or test modes that are not run for every PR.
+
+        Please fill in as much of the form below as you're able.
+  - type: input
+    attributes:
+      label: Test
+      description: The test that is flaky.
+      placeholder: e.g. `test-fs-stat-bigint`
+    validations:
+      required: true
+  - type: input
+    attributes:
+      label: Platform
+      description: The platform the test is flaky on.
+      placeholder: e.g. `macos` or `linux`
+  - type: textarea
+    attributes:
+      label: Console output
+      description: >
+        A pasted console output from a failed CI job showing the whole failure
+        of the test.
+      render: console
+  - type: textarea
+    attributes:
+      label: Build links
+      description: Links to builds affected by the flaky test.
+      value: '- '
+  - type: textarea
+    attributes:
+      label: Additional information
+      description: >
+        If any investigation has been done, please include any information
+        found, such as how consistently the test fails, whether the failure
+        could be reproduced locally, when the test started failing, or anything
+        else you think is relevant.

.github/label-pr-config.yml

@@ -71,6 +71,7 @@ subSystemLabels:
   # all other tool changes should be marked as such
   /^tools\//: tools
   /^\.eslint|\.remark|\.editorconfig/: tools
+  /^typings\//: typings
 
   ## Dependencies
   # libuv needs an explicit mapping, as the ordinary /deps/ mapping below would
@@ -186,6 +187,7 @@ allJsSubSystems:
   - timers
   - tls
   - tty
+  - typings
   - url
   - util
   - v8

.github/workflows/auto-start-ci.yml

@@ -60,4 +60,6 @@ jobs:
           ncu-config set repo ${{ env.REPOSITORY }}
 
       - name: Start CI
-        run: ./tools/actions/start-ci.sh ${{ secrets.GITHUB_TOKEN }} ${{ env.OWNER }} ${{ env.REPOSITORY }} $(echo '${{ steps.get_prs_for_ci.outputs.data }}' | jq '.repository.pullRequests.nodes | map(.number) | .[]')
+        run: ./tools/actions/start-ci.sh $(echo '${{ steps.get_prs_for_ci.outputs.data }}' | jq '.repository.pullRequests.nodes | map(.number) | .[]')
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/build-windows.yml

@@ -2,6 +2,8 @@ name: build-windows
 
 on:
   pull_request:
+    paths-ignore:
+      - "README.md"
     types: [opened, synchronize, reopened, ready_for_review]
   push:
     branches:
@@ -10,6 +12,8 @@ on:
       - canary
       - v[0-9]+.x-staging
       - v[0-9]+.x
+    paths-ignore:
+      - "README.md"
 
 env:
   PYTHON_VERSION: '3.10'

.github/workflows/commit-lint.yml

@@ -9,15 +9,17 @@ jobs:
   lint-commit-message:
     runs-on: ubuntu-latest
     steps:
+      - name: Compute number of commits in the PR
+        id: nb-of-commits
+        run: echo "::set-output name=nb::$((${{ github.event.pull_request.commits }} + 1))"
       - uses: actions/checkout@v2
         with:
-          # Last 100 commits should be enough for a PR
-          fetch-depth: 100
+          fetch-depth: ${{ steps.nb-of-commits.outputs.nb }}
       - name: Install Node.js
         uses: actions/setup-node@v2
         with:
           node-version: ${{ env.NODE_VERSION }}
       - name: Validate commit messages
         run: |
           echo "::add-matcher::.github/workflows/commit-lint-problem-matcher.json"
-          git log --oneline ${{ github.event.pull_request.base.sha }}..${{ github.event.pull_request.head.sha }} | grep -v -e fixup -e squash | awk '{ print $1 }' |  xargs npx -q core-validate-commit --no-validate-metadata --tap
+          git log --oneline -${{ github.event.pull_request.commits }} HEAD^ | awk '{ if ($2 != "fixup!" && $2 != "squash!") { print $1 } }' | xargs npx -q core-validate-commit --no-validate-metadata --tap

.github/workflows/commit-queue.yml

@@ -78,4 +78,6 @@ jobs:
           ncu-config set owner "${OWNER}"
 
       - name: Start the commit queue
-        run: ./tools/actions/commit-queue.sh ${OWNER} ${REPOSITORY} ${{ secrets.GITHUB_TOKEN }} $(echo '${{ steps.get_mergable_pull_requests.outputs.data }}' | jq '.repository.pullRequests.nodes | map(.number) | .[]')
+        run: ./tools/actions/commit-queue.sh ${OWNER} ${REPOSITORY} $(echo '${{ steps.get_mergable_pull_requests.outputs.data }}' | jq '.repository.pullRequests.nodes | map(.number) | .[]')
+        env:
+          GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }}

.github/workflows/find-inactive-collaborators.yml

@@ -13,7 +13,7 @@ env:
 
 jobs:
   find:
-
+    if: github.repository == 'nodejs/node'
     runs-on: ubuntu-latest
 
     steps:
@@ -35,6 +35,7 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }}
         with:
           author: Node.js GitHub Bot <[email protected]>
+          branch: actions/inactive-collaborators
           body: This PR was generated by tools/find-inactive-collaborators.yml.
           commit-message: "meta: move one or more collaborators to emeritus"
           labels: meta

.github/workflows/license-builder.yml

@@ -17,6 +17,8 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
+          author: Node.js GitHub Bot <[email protected]>
+          branch: actions/license-builder
           title: "doc: run license-builder"
           body: "License is likely out of date. This is an automatically generated PR by the `license-builder.yml` GitHub Action, which runs `license-builder.sh` and submits a new PR or updates an existing PR."
           commit-message: 'doc: run license-builder'

.github/workflows/linters.yml

@@ -120,7 +120,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
-      - uses: mszostok/codeowners-validator@v0.4.0
+      - uses: mszostok/codeowners-validator@v0.6.0
         with:
           checks: "files,duppatterns"
   lint-pr-url:

.github/workflows/test-linux.yml

@@ -2,6 +2,8 @@ name: test-linux
 
 on:
   pull_request:
+    paths-ignore:
+      - "README.md"
     types: [opened, synchronize, reopened, ready_for_review]
   push:
     branches:
@@ -10,6 +12,8 @@ on:
       - canary
       - v[0-9]+.x-staging
       - v[0-9]+.x
+    paths-ignore:
+      - "README.md"
 
 env:
   PYTHON_VERSION: '3.10'