doc: remove esm no-json-module-loading section

[dnalborczyk]

with v17.1.0 loading json behind the --experimental-json-modules flag has been removed and requires import assertions behind the same flag.

ref: #40758 (comment)

[aduh95]

I think it's a little too early to remove this, we should probably wait for the JSON module support to stabilize first. The most reasonable option is still to either use fs.readFile + JSON.parse or module.createRequire.

[dnalborczyk]

I think it's a little too early to remove this, we should probably wait for the JSON module support to stabilize first. The most reasonable option is still to either use fs.readFile + JSON.parse or module.createRequire.

this is not true anymore, at least without mentioning import assertions:

JSON imports are still experimental and only supported via the `--experimental-json-modules` flag.

otherwise it implies that using this flag will allow json files to be imported by using "es6" module syntax.
everything else follows this in the paragraph as an alternative approach.

[aduh95]

But both are still true:

• JSON imports are still experimental
• they are only supported via the --experimental-json-modules flag.

I don't see how this implies it would be possible to import them without using an assertion. But more importantly, I don't understand how removing this section helps anyone at this point, we should wait for JSON imports to be no longer experimental, and supported without the --experimental-json-modules flag (assertion required or not).

[aduh95]

Marking it officially as requested change to make sure it doesn't land too soon. Before landing, we should ensure that:

• JSON imports are no longer experimental;
• JSON modules are no longer behind the --experimental-json-modules flag.

[GeoffreyBooth]

We could perhaps edit this section to mention both the current non-experimental methods as well as the experimental method. Then later on all we’d need to do is remove the text that says import of JSON is experimental.

[AugustinMauroy]

LGTM but @aduh95 is right

[GeoffreyBooth]

Marking it officially as requested change to make sure it doesn't land too soon. Before landing, we should ensure that:

• JSON imports are no longer experimental;
• JSON modules are no longer behind the --experimental-json-modules flag.

These are both true now, and have been for a long time; and almost a year has passed. Dunno how much longer we want to wait, but it’s probably safe by now.

[aduh95]

Only the latter is true, JSON imports are still experimental ( https://nodejs.org/api/esm.html#json-modules) – and probably need to be until V8 ships a stable implementation of the Import Assertions proposal and the TC39 actually merge the proposal in the official spec.

…

On Thu, Oct 20, 2022, 2:10 PM Geoffrey Booth ***@***.***> wrote: Marking it officially as requested change to make sure it doesn't land too soon. Before landing, we should ensure that: - JSON imports are no longer experimental; - JSON modules are no longer behind the --experimental-json-modules flag. These are both true now, and have been for a long time; and almost a year has passed. Dunno how much longer we want to wait, but it’s probably safe by now. — Reply to this email directly, view it on GitHub <#40770 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADNFTDKNJDLYR6ZWWUE3I33WEF4HFANCNFSM5HWVUZZQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[GeoffreyBooth]

Import assertions are going away. The proposal was replaced with import attributes. We're waiting on a V8 update to change on our side. I think it's better to keep the fs approach as the primary recommendation until this is all sorted out.

[nicolo-ribaudo]

This PR can be closed, that part of the docs does not exist anymore.