v17.1.0 release proposal

.github/ISSUE_TEMPLATE/4-report-a-flaky-test.yml

@@ -0,0 +1,47 @@
+name: Report a flaky test
+description: Report a flaky test in our CI
+title: "Investigate flaky test - "
+labels: ["flaky-test"]
+body:
+  - type: markdown
+    attributes:
+      value: |
+        Thank you for reporting a flaky test.
+
+        Flaky tests are tests that fail occasionally in the Node.js CI, but not
+        consistently enough to block PRs from landing, or that are failing in CI
+        jobs or test modes that are not run for every PR.
+
+        Please fill in as much of the form below as you're able.
+  - type: input
+    attributes:
+      label: Test
+      description: The test that is flaky.
+      placeholder: e.g. `test-fs-stat-bigint`
+    validations:
+      required: true
+  - type: input
+    attributes:
+      label: Platform
+      description: The platform the test is flaky on.
+      placeholder: e.g. `macos` or `linux`
+  - type: textarea
+    attributes:
+      label: Console output
+      description: >
+        A pasted console output from a failed CI job showing the whole failure
+        of the test.
+      render: console
+  - type: textarea
+    attributes:
+      label: Build links
+      description: Links to builds affected by the flaky test.
+      value: '- '
+  - type: textarea
+    attributes:
+      label: Additional information
+      description: >
+        If any investigation has been done, please include any information
+        found, such as how consistently the test fails, whether the failure
+        could be reproduced locally, when the test started failing, or anything
+        else you think is relevant.

.github/workflows/auto-start-ci.yml

@@ -60,4 +60,6 @@ jobs:
           ncu-config set repo ${{ env.REPOSITORY }}
 
       - name: Start CI
-        run: ./tools/actions/start-ci.sh ${{ secrets.GITHUB_TOKEN }} ${{ env.OWNER }} ${{ env.REPOSITORY }} $(echo '${{ steps.get_prs_for_ci.outputs.data }}' | jq '.repository.pullRequests.nodes | map(.number) | .[]')
+        run: ./tools/actions/start-ci.sh $(echo '${{ steps.get_prs_for_ci.outputs.data }}' | jq '.repository.pullRequests.nodes | map(.number) | .[]')
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/build-windows.yml

@@ -2,6 +2,8 @@ name: build-windows
 
 on:
   pull_request:
+    paths-ignore:
+      - "README.md"
     types: [opened, synchronize, reopened, ready_for_review]
   push:
     branches:
@@ -10,6 +12,8 @@ on:
       - canary
       - v[0-9]+.x-staging
       - v[0-9]+.x
+    paths-ignore:
+      - "README.md"
 
 env:
   PYTHON_VERSION: '3.10'

.github/workflows/commit-lint.yml

@@ -9,15 +9,17 @@ jobs:
   lint-commit-message:
     runs-on: ubuntu-latest
     steps:
+      - name: Compute number of commits in the PR
+        id: nb-of-commits
+        run: echo "::set-output name=nb::$((${{ github.event.pull_request.commits }} + 1))"
       - uses: actions/checkout@v2
         with:
-          # Last 100 commits should be enough for a PR
-          fetch-depth: 100
+          fetch-depth: ${{ steps.nb-of-commits.outputs.nb }}
       - name: Install Node.js
         uses: actions/setup-node@v2
         with:
           node-version: ${{ env.NODE_VERSION }}
       - name: Validate commit messages
         run: |
           echo "::add-matcher::.github/workflows/commit-lint-problem-matcher.json"
-          git log --oneline ${{ github.event.pull_request.base.sha }}..${{ github.event.pull_request.head.sha }} | grep -v -e fixup -e squash | awk '{ print $1 }' |  xargs npx -q core-validate-commit --no-validate-metadata --tap
+          git log --oneline -${{ github.event.pull_request.commits }} HEAD^ | awk '{ if ($2 != "fixup!" && $2 != "squash!") { print $1 } }' | xargs npx -q core-validate-commit --no-validate-metadata --tap

.github/workflows/commit-queue.yml

@@ -78,4 +78,6 @@ jobs:
           ncu-config set owner "${OWNER}"
 
       - name: Start the commit queue
-        run: ./tools/actions/commit-queue.sh ${OWNER} ${REPOSITORY} ${{ secrets.GITHUB_TOKEN }} $(echo '${{ steps.get_mergable_pull_requests.outputs.data }}' | jq '.repository.pullRequests.nodes | map(.number) | .[]')
+        run: ./tools/actions/commit-queue.sh ${OWNER} ${REPOSITORY} $(echo '${{ steps.get_mergable_pull_requests.outputs.data }}' | jq '.repository.pullRequests.nodes | map(.number) | .[]')
+        env:
+          GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }}

.github/workflows/test-linux.yml

@@ -2,6 +2,8 @@ name: test-linux
 
 on:
   pull_request:
+    paths-ignore:
+      - "README.md"
     types: [opened, synchronize, reopened, ready_for_review]
   push:
     branches:
@@ -10,6 +12,8 @@ on:
       - canary
       - v[0-9]+.x-staging
       - v[0-9]+.x
+    paths-ignore:
+      - "README.md"
 
 env:
   PYTHON_VERSION: '3.10'

.mailmap

@@ -12,6 +12,7 @@ Alex Hultman <[email protected]> <[email protected]>
 Alex Jordan <[email protected]>
 Alex Kocharin <[email protected]>
 Alex Kocharin <[email protected]> <[email protected]>
+Alex Zherdev <[email protected]> <[email protected]>
 Alexander Marchenko <[email protected]>
 Alexey Kupershtokh <[email protected]> <[email protected]>
 Alexis Campailla <[email protected]> <[email protected]>
@@ -45,10 +46,12 @@ Ashley Maceli <[email protected]>
 Ashok Suthar <[email protected]>
 Ashutosh Kumar Singh <[email protected]>
 Atsuo Fukaya <[email protected]>
+Azard <[email protected]> <[email protected]>
 Ben Lugavere <[email protected]>
 Ben Noordhuis <[email protected]> <[email protected]>
 Ben Noordhuis <[email protected]> <bnoordhuis@bender.(none)>
 Ben Taber <[email protected]>
+Benedikt Meurer <[email protected]> <[email protected]>
 Benjamin Coe <[email protected]> <[email protected]>
 Benjamin Coe <[email protected]> <[email protected]>
 Benjamin Fleischer <[email protected]> <[email protected]>
@@ -68,6 +71,7 @@ Brandon Benvie <[email protected]> <[email protected]>
 Brandon Kobel <[email protected]> <[email protected]>
 Brendan Ashworth <[email protected]> <[email protected]>
 Brent Pendergraft <[email protected]>
+Brett Kiefer <[email protected]> <[email protected]>
 Brian White <[email protected]>
 Brian White <[email protected]> <[email protected]>
 Caleb Boyd <[email protected]>
@@ -88,24 +92,31 @@ Christopher Lenz <[email protected]> <[email protected]>
 Claudio Rodriguez <[email protected]> <[email protected]>
 Colin Ihrig <[email protected]>
 Corey Martin <[email protected]>
+Cyril Lakech <[email protected]> <[email protected]>
+Daiki Arai <[email protected]> <[email protected]>
 Damien Simonin Feugas <[email protected]>
+Dan Carney <[email protected]>
+Dan Fabulich <[email protected]> <[email protected]>
 Dan Kaplun <[email protected]> <[email protected]>
 Dan Williams <[email protected]> <[email protected]>
 Daniel Abrão <[email protected]>
 Daniel Berger <[email protected]>
 Daniel Bevenius <[email protected]>
 Daniel Chcouri <[email protected]>
+Daniel Clifford <[email protected]>
 Daniel Gröber <[email protected]>
 Daniel Gröber <[email protected]> <[email protected]>
 Daniel Paulino <[email protected]>
 Daniel Pihlström <[email protected]>
 Daniel Wang <[email protected]>
 Daniel Wang <[email protected]> <[email protected]>
 Danielle Adams <[email protected]> <[email protected]>
+Danny Guo <[email protected]> <[email protected]>
 Danny Nemer <[email protected]> <[email protected]>
 Danny Nemer <[email protected]> <[email protected]>
 Darshan Sen <[email protected]>
 Darshan Sen <[email protected]> <[email protected]>
+Dave Olszewski <[email protected]> <[email protected]>
 Dave Pacheco <[email protected]> <[email protected]>
 David Cai <[email protected]>
 David Mark Clements <[email protected]>
@@ -121,8 +132,10 @@ Eduard Burtescu <[email protected]>
 Einar Otto Stangvik <[email protected]>
 Elliott Cable <[email protected]>
 Emanuel Buholzer <[email protected]> <[email protected]>
+Enrico Pertoso <[email protected]>
 Eric Bickle <[email protected]> <[email protected]>
 Eric Phetteplace <[email protected]>
+Erik Corry <[email protected]>
 Ernesto Salazar <[email protected]>
 Erwin W. Ramadhan <[email protected]>
 Ethan Arrowood <[email protected]> <[email protected]>
@@ -148,6 +161,7 @@ Florian Margaine <[email protected]>
 Forrest L Norvell <[email protected]> <[email protected]>
 Forrest L Norvell <[email protected]> <[email protected]>
 Franziska Hinkelmann <[email protected]> <[email protected]>
+Franziska Hinkelmann <[email protected]> <[email protected]>
 Friedemann Altrock <[email protected]>
 Fuji Goro <[email protected]>
 Gabriel de Perthuis <[email protected]>
@@ -190,6 +204,7 @@ Isuru Siriwardana <[email protected]>
 Italo A. Casas <[email protected]> <[email protected]>
 Jackson Tian <[email protected]> <[email protected]>
 Jake Verbaten <[email protected]>
+Jakob Kummerow <[email protected]>
 Jamen Marzonie <[email protected]> <[email protected]>
 James Beavers <[email protected]>
 James Bromwell <[email protected]> <[email protected]>
@@ -205,12 +220,14 @@ Jennifer Bland <[email protected]> <[email protected]>
 JeongHoon Byun <[email protected]>
 Jered Schmidt <[email protected]>
 Jeremiah Senkpiel <[email protected]>
+Jeremy Apthorp <[email protected]> <[email protected]>
 Jérémy Lal <[email protected]>
 Jérémy Lal <[email protected]> <[email protected]>
 Jerry Chin <[email protected]>
 Jessica Quynh Tran <[email protected]>
 Jesús Leganés-Combarro 'piranna <[email protected]>
 Jimb Esser <[email protected]> <[email protected]>
+Jochen Eisinger <[email protected]> 
 Joe Shaw <[email protected]> <[email protected]>
 Johan Bergström <[email protected]>
 Johan Dahlberg <[email protected]> <[email protected]>
@@ -253,6 +270,7 @@ Kazuyuki Yamada <[email protected]>
 Ke Ding <[email protected]>
 Keith M Wesolowski <[email protected]> <[email protected]>
 Kelsey Breseman <[email protected]>
+Kevin Millikin <[email protected]>
 Khaidi Chu <[email protected]>
 Khaidi Chu <[email protected]> <[email protected]>
 Kimberly Wilber <[email protected]>
@@ -266,6 +284,7 @@ Kyle Robinson Young <[email protected]>
 Lakshmi Swetha Gopireddy <[email protected]> <[email protected]>
 Lakshmi Swetha Gopireddy <[email protected]> <[email protected]>
 Lars-Magnus Skog <[email protected]> <[email protected]>
+Lasse R.H. Nielsen <[email protected]>
 Leeseean Chiu <[email protected]>
 Lucas Pardue <[email protected]> <[email protected]>
 Luke Bayes <[email protected]>
@@ -299,8 +318,10 @@ Matthew Lye <[email protected]>
 Matthew Turner <[email protected]> <[email protected]>
 Matthias Bastian <[email protected]> <[email protected]>
 Maurice Hayward <[email protected]>
+Maya Lekova <[email protected]> <[email protected]>
 Michael Bernstein <[email protected]>
 Michael Dawson <[email protected]> <[email protected]>
+Michael Starzinger <[email protected]>
 Michaël Zasso <[email protected]> <[email protected]>
 Michael-Rainabba Richardson <[email protected]>
 Michał Gołębiowski-Owczarek <[email protected]>
@@ -333,6 +354,7 @@ Nikolai Vavilov <[email protected]>
 Nils Kuhnhenn <[email protected]>
 Nitzan Uziely <[email protected]> <[email protected]>
 Noah Rose Ledesma <[email protected]>
+Oliver Chang <[email protected]>
 Oluwaseun Omoyajowo <[email protected]>
 Onne Gorter <[email protected]>
 Oscar Martinez <[email protected]> <[email protected]>
@@ -341,6 +363,7 @@ Paul Querna <[email protected]> <[email protected]>
 Pedro Lima <[email protected]>
 Peng Lyu <[email protected]>
 Peter Flannery <[email protected]>
+Peter Marshall <[email protected]> <[email protected]>
 Peter Marton <[email protected]> <[email protected]>
 Peter Paugh <[email protected]>
 Phillip Johnsen <[email protected]> <[email protected]>
@@ -385,9 +408,9 @@ Sam Roberts <[email protected]> <[email protected]>
 Sam Shull <[email protected]> <[email protected]>
 Sam Shull <[email protected]> <[email protected]>
 Sam Shull <[email protected]> <[email protected]>
-Samuel Attard <[email protected]> <[email protected]>
 Samantha Sample <[email protected]> <=>
 Sambasiva Suda <[email protected]>
+Samuel Attard <[email protected]> <[email protected]>
 San-Tai Hsu <[email protected]>
 Santiago Gimeno <[email protected]> <[email protected]>
 Sarah Meyer <[email protected]>
@@ -423,6 +446,7 @@ Stewart X Addison <[email protected]> <[email protected]>
 Suraiya Hameed <[email protected]>
 Suramya shah <[email protected]> <[email protected]>
 Surya Panikkal <[email protected]>
+Sven Panne <[email protected]>
 Szymon Marczak <[email protected]> <[email protected]>
 Tadashi SAWADA <[email protected]>
 Tadhg Creedon <[email protected]> <[email protected]>
@@ -446,6 +470,7 @@ Tim Price <[email protected]>
 Tim Ruffles <[email protected]> <[email protected]>
 Tim Smart <[email protected]>
 Tim Smart <[email protected]> <[email protected]>
+Timothy Gu <[email protected]> <[email protected]>
 Timothy Leverett <[email protected]>
 Timothy O. Peters <[email protected]>
 Timur Shemsedinov <[email protected]>
@@ -463,20 +488,22 @@ Tom Hughes-Croucher <[email protected]>
 Tom Purcell <[email protected]>
 Tom White <[email protected]>
 Tomoki Okahana <[email protected]>
+Toon Verwaest <[email protected]>
 Tracy Hinds <[email protected]>
 Travis Meisenheimer <[email protected]> <[email protected]>
 Trevor Burnham <[email protected]> <[email protected]>
 Trivikram Kamat <[email protected]> <[email protected]>
 ttzztztz <[email protected]> <[email protected]>
 Tyler Larson <[email protected]>
-Ujjwal Sharma <[email protected]> <[email protected]>
 Ujjwal Sharma <[email protected]> <[email protected]>
+Ujjwal Sharma <[email protected]> <[email protected]>
 Uttam Pawar <[email protected]> <[email protected]>
 Viktor Karpov <[email protected]>
 Vincent Voyer <[email protected]>
 Vladimir de Turckheim <[email protected]>
 Voltrex <[email protected]> <[email protected]>
 vsemozhetbyt <[email protected]>
+Vyacheslav Egorov <[email protected]>
 Wang Xinyong <[email protected]> <[email protected]>
 Wei-Wei Wu <[email protected]>
 Weijia Wang <[email protected]>
@@ -490,6 +517,7 @@ Xavier J Ortiz <[email protected]>
 xiaoyu <[email protected]>
 Xu Meng <[email protected]> <[email protected]>
 Yael Hermon <[email protected]> <[email protected]>
+Yang Guo <[email protected]>
 ycjcl868 <[email protected]> <[email protected]>
 Yingchen Xue <[email protected]>
 Yongsheng Zhang <[email protected]>
@@ -507,15 +535,3 @@ Zachary Vacura <[email protected]>
 Zoran Tomicic <[email protected]>
 Сковорода Никита Андреевич <[email protected]>
 隋鑫磊 <[email protected]>
-
-# These people didn't contribute patches to node directly,
-# but we've landed their v8 patches in the node repository:
-Daniel Clifford <[email protected]>
-Erik Corry <[email protected]>
-Jakob Kummerow <[email protected]>
-Kevin Millikin <[email protected]>
-Lasse R.H. Nielsen <[email protected]>
-Michael Starzinger <[email protected]>
-Toon Verwaest <[email protected]>
-Vyacheslav Egorov <[email protected]>
-Yang Guo <[email protected]>