Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: rename unknown primordial #40622

Closed
wants to merge 2 commits into from
Closed

stream: rename unknown primordial #40622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa69325
stream: rename unknown primordial
VoltrexKeyva Oct 27, 2021
429009a
test: add DataView test entry for whatwg
VoltrexKeyva Oct 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/internal/webstreams/readablestream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const {
ArrayBufferPrototypeSlice,
ArrayPrototypePush,
ArrayPrototypeShift,
DataViewCtor,
DataView,
FunctionPrototypeBind,
FunctionPrototypeCall,
MathMin,
Expand Down Expand Up @@ -2132,7 +2132,7 @@ function readableByteStreamControllerPullInto(
pendingPullIntos,
} = controller[kState];
let elementSize = 1;
let ctor = DataViewCtor;
let ctor = DataView;
if (isArrayBufferView(view) && !isDataView(view)) {
elementSize = view.constructor.BYTES_PER_ELEMENT;
ctor = view.constructor;
Expand Down
15 changes: 15 additions & 0 deletions test/parallel/test-whatwg-readablestream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1602,3 +1602,18 @@ class Source {
isReadable(stream, false);
})().then(common.mustCall());
}

{
const stream = new ReadableStream({
type: 'bytes',
start(controller) {
controller.close();
}
});

const buffer = new ArrayBuffer(1024);
const reader = stream.getReader({ mode: 'byob' });

reader.read(new DataView(buffer))
.then(common.mustCall());
}