Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix environment variable settings for ccache #40550

Merged
merged 2 commits into from
Oct 24, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 21, 2021

macOS requires cc and c++ rather than gcc and g++.

Closes: #40542

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Oct 21, 2021
@Trott

This comment has been minimized.

Copy link
Member

@GeoffreyBooth GeoffreyBooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closes #40542

BUILDING.md Outdated Show resolved Hide resolved
BUILDING.md Outdated Show resolved Hide resolved
@Mesteery Mesteery added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 21, 2021
Comment on lines -524 to -525
$ ccache -o cache_dir=<tmp_dir>
$ ccache -o max_size=5.0G
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be dropping these?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be dropping these?

ccache has a reasonable default for cache_dir so that removes the necessity to set a cache_dir explicitly. Ref: https://ccache.dev/manual/4.3.html#config_cache_dir

max_size default is 5Gb, so we don't need the step that explicitly sets it to 5Gb as well. Ref: https://ccache.dev/manual/4.3.html#config_max_size

BUILDING.md Show resolved Hide resolved
@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 24, 2021
@github-actions github-actions bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 24, 2021
@github-actions
Copy link
Contributor

Commit Queue failed
- Loading data for nodejs/node/pull/40550
✔  Done loading data for nodejs/node/pull/40550
----------------------------------- PR info ------------------------------------
Title      doc: fix environment variable settings for ccache (#40550)
Author     Rich Trott  (@Trott)
Branch     Trott:build-ccache -> nodejs:master
Labels     doc, build, author ready
Commits    3
 - doc: fix environment variable settings for ccache
 - doc: format BUILDING.md
 - doc: simplify ccache instructions
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/40550
Fixes: https://github.com/nodejs/node/issues/40542
Reviewed-By: Geoffrey Booth 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/40550
Fixes: https://github.com/nodejs/node/issues/40542
Reviewed-By: Geoffrey Booth 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 21 Oct 2021 17:15:20 GMT
   ✔  Approvals: 3
   ✔  - Geoffrey Booth (@GeoffreyBooth): https://github.com/nodejs/node/pull/40550#pullrequestreview-785998018
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/40550#pullrequestreview-786016926
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/40550#pullrequestreview-786090196
   ✔  Last GitHub Actions successful
   ℹ  Green GitHub Actions CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/master up to date...
From https://github.com/nodejs/node
 * branch                  master     -> FETCH_HEAD
✔  origin/master is now up-to-date
- Downloading patch for 40550
From https://github.com/nodejs/node
 * branch                  refs/pull/40550/merge -> FETCH_HEAD
✔  Fetched commits as 40d890d31d6f..b57e2b0a64be
--------------------------------------------------------------------------------
Auto-merging BUILDING.md
[master e7817f7d32] doc: fix environment variable settings for ccache
 Author: Rich Trott 
 Date: Thu Oct 21 10:06:49 2021 -0700
 1 file changed, 12 insertions(+)
Auto-merging BUILDING.md
The previous cherry-pick is now empty, possibly due to conflict resolution.
If you wish to commit it anyway, use:
git commit --allow-empty

Otherwise, please use 'git cherry-pick --skip'
On branch master
Your branch is ahead of 'origin/master' by 1 commit.
(use "git push" to publish your local commits)

Cherry-pick currently in progress.
(run "git cherry-pick --continue" to continue)
(use "git cherry-pick --skip" to skip this patch)
(use "git cherry-pick --abort" to cancel the cherry-pick operation)

Untracked files:
(use "git add ..." to include in what will be committed)
output

nothing added to commit but untracked files present (use "git add" to track)
✖ Failed to apply patches

https://github.com/nodejs/node/actions/runs/1377942911

macOS requires `cc` and `c++` rather than `gcc` and `g++`.

Closes: nodejs#40542

PR-URL: nodejs#40550
Fixes: nodejs#40542
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
`ccache` has reasonable defaults for `max_size` and `cache_dir` so
remove instructions to set those things explicitly.

Change fenced code from `console` to `bash` for easier copy/paste.

PR-URL: nodejs#40550
Fixes: nodejs#40542
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@Trott
Copy link
Member Author

Trott commented Oct 24, 2021

Landed in 40d890d...31d7d6c

@Trott Trott merged commit 31d7d6c into nodejs:master Oct 24, 2021
@Trott Trott deleted the build-ccache branch October 24, 2021 14:01
targos pushed a commit that referenced this pull request Nov 6, 2021
macOS requires `cc` and `c++` rather than `gcc` and `g++`.

Closes: #40542

PR-URL: #40550
Fixes: #40542
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Nov 6, 2021
`ccache` has reasonable defaults for `max_size` and `cache_dir` so
remove instructions to set those things explicitly.

Change fenced code from `console` to `bash` for easier copy/paste.

PR-URL: #40550
Fixes: #40542
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Nov 8, 2021
BethGriggs pushed a commit that referenced this pull request Nov 25, 2021
macOS requires `cc` and `c++` rather than `gcc` and `g++`.

Closes: #40542

PR-URL: #40550
Fixes: #40542
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
BethGriggs pushed a commit that referenced this pull request Nov 25, 2021
`ccache` has reasonable defaults for `max_size` and `cache_dir` so
remove instructions to set those things explicitly.

Change fenced code from `console` to `bash` for easier copy/paste.

PR-URL: #40550
Fixes: #40542
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Nov 26, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building Node.js broken when using ccache
8 participants