stream: fix fromAsyncGen #40499
Closed
stream: fix fromAsyncGen #40499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nodejs/streams |
ronag
added
author ready
|
Credit to @kmamal for making me aware of this issue and writing a repro. |
github-actions
bot
removed
the
request-ci
25 tasks
Merged
|
@benjamingr @lpinca @jasnell would appreciate another review here so we can land it in the next release. |
benjamingr
approved these changes
Oct 19, 2021
|
Can we fast-track this so it can be included in 16.12 #40504 (comment) |
|
Fast-track has been requested by @ronag. Please 👍 to approve. |
richardlau
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in 2bed031...0f78d26 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 19, 2021
Fixes: #40497 PR-URL: #40499 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Oct 19, 2021
Fixes: #40497 PR-URL: #40499 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
27 tasks
targos
pushed a commit
that referenced
this pull request
Oct 20, 2021
Fixes: #40497 PR-URL: #40499 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
targos
added a commit
that referenced
this pull request
Oct 20, 2021
Notable changes: Fixed distribution for native addon builds This release fixes an issue introduced in Node.js v17.0.0, where some V8 headers were missing from the distributed tarball, making it impossible to build native addons. These headers are now included. #40526 Fixed stream issues * Fixed a regression in `stream.promises.pipeline`, which was introduced in version 16.10.0, is fixed. It is now possible again to pass an array of streams to the function. #40193 * Fixed a bug in `stream.Duplex.from`, which didn't work properly when an async generator function was passed to it. #40499 PR-URL: #40535
targos
added a commit
that referenced
this pull request
Oct 20, 2021
Notable changes: Fixed distribution for native addon builds This release fixes an issue introduced in Node.js v17.0.0, where some V8 headers were missing from the distributed tarball, making it impossible to build native addons. These headers are now included. #40526 Fixed stream issues * Fixed a regression in `stream.promises.pipeline`, which was introduced in version 16.10.0, is fixed. It is now possible again to pass an array of streams to the function. #40193 * Fixed a bug in `stream.Duplex.from`, which didn't work properly when an async generator function was passed to it. #40499 PR-URL: #40535
This was referenced Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #40497
The problem here is that the resolve does not get updated before yielding control back to the user, hence the user might call the wrong resolve and hang the pipeline.