Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: patch V8 to 9.5.172.21 #40432

Closed
wants to merge 1 commit into from
Closed

deps: patch V8 to 9.5.172.21 #40432

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Oct 12, 2021

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Oct 12, 2021
@gengjiawen gengjiawen added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 13, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 13, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 13, 2021 •
edited by targos
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/40268/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4323/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40271/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40280/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40287/

@github-actions github-actions bot mentioned this pull request Oct 14, 2021
Open
22 tasks
@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 14, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @targos. Please 👍 to approve.

@targos
Copy link
Member Author

targos commented Oct 14, 2021

I'd like to fast track to get it into Node.js 17.0.0

/cc @BethGriggs

targos added a commit that referenced this pull request Oct 14, 2021
@targos
deps: patch V8 to 9.5.172.21
bf82dcd 
Refs: v8/v8@9.5.172.19...9.5.172.21

PR-URL: #40432
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
@targos
Copy link
Member Author

targos commented Oct 14, 2021

Landed in bf82dcd

@targos targos closed this Oct 14, 2021
@targos targos deleted the v8-9.5.172.20 branch October 14, 2021 14:46
@github-actions github-actions bot mentioned this pull request Oct 15, 2021
Open
23 tasks
@BethGriggs BethGriggs mentioned this pull request Oct 15, 2021
Merged
2 tasks
This was referenced Oct 16, 2021
Open
Open
Open
Open
@github-actions github-actions bot mentioned this pull request Oct 20, 2021
Open
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BethGriggs BethGriggs BethGriggs approved these changes

@richardlau richardlau richardlau approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@targos @nodejs-github-bot @cjihrig @gengjiawen @richardlau @BethGriggs