Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update addons.md #40417

Closed
wants to merge 1 commit into from
Closed

Update addons.md #40417

wants to merge 1 commit into from

Conversation

dsamaniegov
Copy link

Syntax error in example

Syntax error in example
@nodejs-github-bot nodejs-github-bot added addons Issues and PRs related to native addons. doc Issues and PRs related to the documentations. labels Oct 12, 2021
@@ -81,7 +81,7 @@ void Initialize(Local<Object> exports) {
NODE_SET_METHOD(exports, "hello", Method);
}

NODE_MODULE(NODE_GYP_MODULE_NAME, Initialize)
NODE_MODULE(NODE_GYP_MODULE_NAME, Initialize);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #12919.

@Trott
Copy link
Member

Trott commented Oct 12, 2021

Welcome, @dsamaniegov, and thanks for the pull request. Per richardlau's comment, I'm going to close this, but feel free to comment if you think that's in error. Thanks!

@Trott Trott closed this Oct 12, 2021
@dsamaniegov dsamaniegov deleted the patch-1 branch October 12, 2021 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addons Issues and PRs related to native addons. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants