typings: improve internal bindings typings #40411
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
targos
reviewed
Oct 12, 2021
| type StringOrBuffer = string | Buffer; | ||
|
|
||
| const kUsePromises: symbol; | ||
| const kUsePromises: unique symbol; |
There was a problem hiding this comment.
does it work now? Last time I tried, if checkJs was on, it introduced errors.
There was a problem hiding this comment.
It doesn't seem to me that there were any errors. It remains to be verified
There was a problem hiding this comment.
I checked, there is no error with unique symbol.
targos
approved these changes
Oct 12, 2021
jasnell
approved these changes
Oct 24, 2021
Mesteery
force-pushed
the
improve-bindings-typings
branch
from
1bf68f3
to
805653e
Compare
Mesteery
added
the
author ready
Ayase-252
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in 3ff8c35...b66a75a |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 28, 2021
PR-URL: #40411 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 6, 2021
PR-URL: #40411 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Nov 25, 2021
PR-URL: #40411 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #40409.