-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: update AUTHORS #40392
meta: update AUTHORS #40392
Conversation
Well, that didn't work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I manually confirmed that none of these are duplicates so this is ready to land.
Fast-track has been requested by @Trott. Please 👍 to approve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
Commit Queue failed- Loading data for nodejs/node/pull/40392 ✔ Done loading data for nodejs/node/pull/40392 ----------------------------------- PR info ------------------------------------ Title meta: update AUTHORS (#40392) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/authors-update -> nodejs:master Labels meta, fast-track, author ready Commits 1 - meta: update AUTHORS Committers 1 - Node.js GitHub Bot PR-URL: https://github.com/nodejs/node/pull/40392 Reviewed-By: Rich Trott Reviewed-By: Tobias Nießen Reviewed-By: Antoine du Hamel ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40392 Reviewed-By: Rich Trott Reviewed-By: Tobias Nießen Reviewed-By: Antoine du Hamel -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 10 Oct 2021 00:14:07 GMT ✔ Approvals: 3 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/40392#pullrequestreview-775618121 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/40392#pullrequestreview-775620278 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/40392#pullrequestreview-775713003 ℹ This PR is being fast-tracked ✖ GitHub CI is still running ℹ Green GitHub Actions CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1326708013 |
PR-URL: #40392 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
31b9603
to
49b7ec9
Compare
Landed in 49b7ec9 |
PR-URL: #40392 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Here are some new additions to the AUTHORS file. This is an automatically generated PR by the
authors.yml
GitHub Action, which runstools/update-authors.js
.{{ env.DUPLICATES }}