-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v16.x backport] URL WPT changes #40383
Commits on Oct 9, 2021
-
doc: anchor link parity between markdown and html-generated docs
Main changes: - Replace current HTML anchor generation to match header anchor generation in Github markdown. - Remove unnecessary double namespacing on generated anchors/links (E.G. `esm.md#loaders` instead of `esm.md#esm_loaders`). - Anchors/links are automatically prefixed with their respective modules when concatenated for usage in `all.html`. Benefits: - All anchor links within and between markdown API docs actually work. - Adding new anchor links no longer requires contributors to generate the HTML docs first to look up the correct anchors. - Anchors are much shorter. - All previous anchor links are preserved by generating hidden legacy anchors. PR-URL: nodejs#39304 Reviewed-By: Antoine du Hamel <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d3f3111 - Browse repository at this point
Copy the full SHA d3f3111View commit details -
esm: consolidate ESM loader hooks
doc: update ESM hook examples esm: fix unsafe primordial doc: fix ESM example linting esm: allow source of type ArrayBuffer doc: update ESM hook changelog to include resolve format esm: allow all ArrayBuffers and TypedArrays for load hook source doc: tidy code & API docs doc: convert ESM source table header from Title Case to Sentence case doc: add detailed explanation for getPackageType esm: add caveat that ESMLoader::import() must NOT be renamed esm: tidy code declaration of getFormat protocolHandlers doc: correct ESM doc link (bad conflict resolution) doc: update ESM hook limitation for CJS esm: tweak preload description doc: update ESM getPackageType() example explanation PR-URL: nodejs#37468 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7bc0d7c - Browse repository at this point
Copy the full SHA 7bc0d7cView commit details -
v8: remove --harmony-top-level-await
PR-URL: nodejs#40226 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 07ea5c6 - Browse repository at this point
Copy the full SHA 07ea5c6View commit details -
crypto: remove incorrect constructor invocation
PR-URL: nodejs#40300 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 954df09 - Browse repository at this point
Copy the full SHA 954df09View commit details -
doc: deprecate (doc-only) http abort related
Refs: nodejs#36641 Refs: nodejs#36617 (comment) Documentation-only deprecate `.aborted` property and `'abort'`, `'aborted'` event in `http`, and suggest using the corresponding Stream API instead. Co-authored-by: Michaël Zasso <[email protected]> Co-authored-by: Rich Trott <[email protected]> Co-authored-by: Robert Nagy <[email protected]> Co-authored-by: Antoine du Hamel <[email protected]> PR-URL: nodejs#36670 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4da1318 - Browse repository at this point
Copy the full SHA 4da1318View commit details -
doc: assign missing deprecation number
Refs: nodejs#36670 PR-URL: nodejs#40324 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a5a3a93 - Browse repository at this point
Copy the full SHA a5a3a93View commit details -
Refs: nodejs#37468 PR-URL: nodejs#40275 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f0ecb6e - Browse repository at this point
Copy the full SHA f0ecb6eView commit details -
_subpath_ is not defined in this context. This is pretty clearly meant to be _packageSubpath_, which is the second argument to `PACKAGE_SELF_RESOLVE` PR-URL: nodejs#40273 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for daa61b4 - Browse repository at this point
Copy the full SHA daa61b4View commit details -
doc: correct ESM load hook table header
`resolve` does not return a `source` property PR-URL: nodejs#40234 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for cef6838 - Browse repository at this point
Copy the full SHA cef6838View commit details -
lib,url: correct URL's argument to pass idlharness
`url.idl` defines URL's constructor as: ``` constructor(USVString url, optional USVString base); ``` `idlharness.any.js` checks its length as `1`. So we should remove constructor's second argument and use `arguments[1]` in constructor's logic. Refs: https://url.spec.whatwg.org/#idl-index PR-URL: nodejs#39848 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for bf377f2 - Browse repository at this point
Copy the full SHA bf377f2View commit details -
test: pass URL's toascii.window.js WPT
PR-URL: nodejs#39910 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1310399 - Browse repository at this point
Copy the full SHA 1310399View commit details