Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test for readStream.path when fd is specified #40359

Closed
wants to merge 1 commit into from
Closed

test: add test for readStream.path when fd is specified #40359

wants to merge 1 commit into from

Conversation

Ayase-252
Copy link
Member

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 7, 2021
@Ayase-252 Ayase-252 added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 7, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 7, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40194/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40199/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40200/

@Ayase-252 Ayase-252 mentioned this pull request Oct 7, 2021
Closed
@github-actions github-actions bot mentioned this pull request Oct 8, 2021
Open
23 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40211/

@Ayase-252 Ayase-252 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 8, 2021
@github-actions github-actions bot mentioned this pull request Oct 9, 2021
Open
21 tasks
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 9, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 9, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2021

Landed in 24f045d...eafdeab

@github-actions github-actions bot closed this Oct 9, 2021
nodejs-github-bot pushed a commit that referenced this pull request Oct 9, 2021
@Ayase-252 @nodejs-github-bot
test: add test for readStream.path when fd is specified
eafdeab 
Refs: #40252 (review)

PR-URL: #40359
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@github-actions github-actions bot mentioned this pull request Oct 10, 2021
Open
18 tasks
@Ayase-252 Ayase-252 deleted the test/fs/readstream-path-may-be-undefined branch October 10, 2021 06:15
This was referenced Oct 11, 2021
Open
Open
targos pushed a commit that referenced this pull request Oct 13, 2021
@Ayase-252 @targos
test: add test for readStream.path when fd is specified
641b1bb 
Refs: #40252 (review)

PR-URL: #40359
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@github-actions github-actions bot mentioned this pull request Oct 14, 2021
Open
22 tasks
@BethGriggs BethGriggs mentioned this pull request Oct 14, 2021
Merged
2 tasks
@richardlau richardlau mentioned this pull request Oct 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@evanlucas evanlucas evanlucas approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Ayase-252 @nodejs-github-bot @jasnell @evanlucas @lpinca @aduh95