Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix CVE-2021-22940 references #40308

Closed
wants to merge 1 commit into from
Closed

doc: fix CVE-2021-22940 references #40308

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Oct 4, 2021

Fixes: #40306

@nodejs-github-bot nodejs-github-bot added the release Issues and PRs related to Node.js releases. label Oct 4, 2021
@targos targos mentioned this pull request Oct 4, 2021
Closed
mcollina
mcollina approved these changes Oct 4, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 4, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2021

Fast-track has been requested by @targos. Please 👍 to approve.

@tniessen
Copy link
Member

tniessen commented Oct 4, 2021

cc @nodejs/security @nodejs/security-wg

@targos targos added doc Issues and PRs related to the documentations. request-ci Add this label to start a Jenkins CI on a PR. and removed release Issues and PRs related to Node.js releases. labels Oct 4, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 4, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40149/

mhdawson
mhdawson approved these changes Oct 4, 2021
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot mentioned this pull request Oct 5, 2021
Open
21 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40154/

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 5, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 5, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2021

Landed in cbd61c9...658612b

@github-actions github-actions bot closed this Oct 5, 2021
nodejs-github-bot pushed a commit that referenced this pull request Oct 5, 2021
@targos @nodejs-github-bot
doc: fix CVE-2021-22940 references
658612b 
Fixes: #40306

PR-URL: #40308
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Vladimir de Turckheim <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@targos targos deleted the fix-cve-22940 branch October 5, 2021 05:18
@danielleadams
Copy link
Contributor

@targos how should this be cherry-picked into v16? Can I leave out the v14 and v12 changes from the commit?

danielleadams pushed a commit that referenced this pull request Oct 5, 2021
@targos @danielleadams
doc: fix CVE-2021-22940 references
e2cd2f4 
Fixes: #40306

PR-URL: #40308
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Vladimir de Turckheim <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@danielleadams danielleadams mentioned this pull request Oct 5, 2021
Merged
@github-actions github-actions bot mentioned this pull request Oct 6, 2021
Open
24 tasks
@targos
Copy link
Member Author

targos commented Oct 6, 2021

@danielleadams yes, that seems good to me!

This was referenced Oct 7, 2021
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanarbol juanarbol juanarbol approved these changes

@mhdawson mhdawson mhdawson approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@vdeturckheim vdeturckheim vdeturckheim approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possible wrong CVE-2021-22930 reference (should be CVE-2021-22940) in tagged v16.6.2 / v14.17.5 releases