net: fix IPv4 validation regex #40174
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
VoltrexKeyva
force-pushed
the
patch-5
branch
2 times, most recently
from
4dc46b6 to
7e8cb99
Compare
mscdex
suggested changes
Sep 21, 2021
|
@mscdex that is quite interesting, although I don't it is really necessary to worry about those since most of the software will interpret them as base-10, I don't think those said softwares would even support these builds whatsoever, maybe we should also wait for other TSC members or collabrators reviews on this as well. |
Fixed the IPv4's validation regex so it also matches IPv4 octets that are prefixed by a `0` as they're also considered valid octets. Fixes: nodejs#40173
VoltrexKeyva
force-pushed
the
patch-5
branch
from
7e8cb99 to
0f67d43
Compare
|
Oh didn't realize that, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the IPv4's validation regex so it also matches IPv4 octets that are prefixed by a
0as they're also considered valid octets.Fixes: #40173