Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix typo 'maxHeaderSize' in http.md #40164

Closed
wants to merge 1 commit into from
Closed

doc: fix typo 'maxHeaderSize' in http.md #40164

wants to merge 1 commit into from

Conversation

rebhialfa
Copy link
Contributor

No description provided.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Sep 20, 2021
@rebhialfa rebhialfa changed the title fix typo in 'maxHeaderSize' doc: fix typo 'maxHeaderSize' in http.md Sep 20, 2021
mhdawson
mhdawson approved these changes Sep 20, 2021
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @jasnell should comment as well.

@Ayase-252 Ayase-252 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 23, 2021
jasnell pushed a commit that referenced this pull request Sep 25, 2021
@rebhialfa @jasnell
doc: fix typo in 'maxHeaderSize'
25ffd39 
PR-URL: #40164
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Sep 25, 2021

Landed in 25ffd39

@jasnell jasnell closed this Sep 25, 2021
targos pushed a commit that referenced this pull request Oct 4, 2021
@rebhialfa @targos
doc: fix typo in 'maxHeaderSize'
6bf6790 
PR-URL: #40164
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Oct 4, 2021
Merged
@rebhialfa rebhialfa deleted the patch-1 branch October 20, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lxxyx Lxxyx Lxxyx approved these changes

@mhdawson mhdawson mhdawson approved these changes

@tniessen tniessen tniessen approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@rebhialfa @jasnell @lpinca @tniessen @mhdawson @Lxxyx @Ayase-252 @nodejs-github-bot