Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: mark compose as experimental #39494

Closed
wants to merge 1 commit into from
Closed

stream: mark compose as experimental #39494

wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Jul 23, 2021

Given #39483 it seems prudent to mark stream.compose as experimental for now.

@ronag ronag requested a review from mcollina July 23, 2021 05:47
@ronag
Copy link
Member Author

ronag commented Jul 23, 2021

@nodejs/streams

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Jul 23, 2021
mcollina
mcollina approved these changes Jul 23, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 23, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 23, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39234/

@ronag ronag added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 24, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 24, 2021
@github-actions
Copy link
Contributor

Commit Queue failed
- Loading data for nodejs/node/pull/39494
✔  Done loading data for nodejs/node/pull/39494
----------------------------------- PR info ------------------------------------
Title      stream: mark compose as experimental (#39494)
Author     Robert Nagy  (@ronag)
Branch     ronag:compose-experimental -> nodejs:master
Labels     author ready, doc, stream
Commits    1
 - stream: mark compose as experimental
Committers 1
 - Robert Nagy 
PR-URL: https://github.com/nodejs/node/pull/39494
Reviewed-By: Michaël Zasso 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Matteo Collina 
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/39494
Reviewed-By: Michaël Zasso 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Matteo Collina 
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 23 Jul 2021 05:47:16 GMT
   ✔  Approvals: 4
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/39494#pullrequestreview-713414599
   ✔  - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/39494#pullrequestreview-713422146
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/39494#pullrequestreview-713432290
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/39494#pullrequestreview-713862106
   ✖  This PR needs to wait 17 more hours to land
   ✔  Last GitHub Actions successful
   ℹ  Green GitHub Actions CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1062446009

@github-actions github-actions bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Jul 24, 2021
ronag added a commit that referenced this pull request Jul 25, 2021
@ronag
stream: mark compose as experimental
ab03ab4 
PR-URL: #39494
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@ronag
Copy link
Member Author

ronag commented Jul 25, 2021

Landed in ab03ab4

@ronag ronag closed this Jul 25, 2021
@targos
Copy link
Member

targos commented Jul 26, 2021

Depends on #39029

ronag added a commit to nxtedition/node that referenced this pull request Jul 28, 2021
@ronag
stream: mark compose as experimental
b9173df 
PR-URL: nodejs#39494
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@ronag
Copy link
Member Author

ronag commented Jul 28, 2021

#39563

ronag added a commit to nxtedition/node that referenced this pull request Jul 29, 2021
@ronag
stream: mark compose as experimental
9f1b9b2 
PR-URL: nodejs#39494
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
ronag added a commit to nxtedition/node that referenced this pull request Jul 29, 2021
@ronag
stream: mark compose as experimental
d2d414d 
PR-URL: nodejs#39494
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
ronag added a commit to nxtedition/node that referenced this pull request Aug 1, 2021
@ronag
stream: mark compose as experimental
f6d0401 
PR-URL: nodejs#39494
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
ronag added a commit to nxtedition/node that referenced this pull request Aug 1, 2021
@ronag
stream: mark compose as experimental
b997463 
PR-URL: nodejs#39494
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
ronag added a commit to nxtedition/node that referenced this pull request Aug 1, 2021
@ronag
stream: mark compose as experimental
8d21a3e 
PR-URL: nodejs#39494
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
ronag added a commit to nxtedition/node that referenced this pull request Aug 23, 2021
@ronag
stream: mark compose as experimental
02155dc 
PR-URL: nodejs#39494
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
ronag added a commit to nxtedition/node that referenced this pull request Aug 23, 2021
@ronag
stream: mark compose as experimental
bb6bedf 
PR-URL: nodejs#39494
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Aug 24, 2021
Closed
@targos targos added backported-to-v16.x and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. backport-open-v16.x labels Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@benjamingr benjamingr benjamingr approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ronag @nodejs-github-bot @targos @mcollina @jasnell @benjamingr