Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade npm to 7.18.1 #39065

Closed
wants to merge 1 commit into from
Closed

deps: upgrade npm to 7.18.1 #39065

wants to merge 1 commit into from

Conversation

npm-robot
Copy link
Contributor

@npm-robot npm-robot commented Jun 17, 2021 •
edited by ruyadorno
Loading

v7.18.1 (2021-06-17)

BUG FIXES

v7.18.0 (2021-06-17)

FEATURES

BUG FIXES

DEPENDENCIES

@github-actions github-actions bot added dont-land-on-v12.x fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry. labels Jun 17, 2021
@wraithgar

This comment has been minimized.

Sign in to view
@wraithgar
Copy link

7.18.0 had an issue that prevented us from making this PR without the fix that was in v7.18.1. I have added the 7.18.0 changelog as a comment, which may need to be moved into the PR description itself (I do not have access to do this).

@lpinca
Copy link
Member

lpinca commented Jun 17, 2021 •
edited
Loading

I think it should be v7.18.1 (2021-06-17) instead of v7.18.0 (2021-06-17) in the PR description created by npm-robot but I see the same issue here https://github.com/npm/cli/releases/tag/v7.18.1.

lpinca
lpinca approved these changes Jun 17, 2021
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@ruyadorno
Copy link
Member

@lpinca yep 👍 fixed it!

@ruyadorno ruyadorno added fast-track PRs that do not need to wait for 48 hours to land. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Jun 17, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @ruyadorno. Please 👍 to approve.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38670/

MylesBorins
MylesBorins approved these changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darcyclarke darcyclarke mentioned this pull request Jun 18, 2021
Closed
3 tasks
ruyadorno pushed a commit that referenced this pull request Jun 18, 2021
@npm-robot @ruyadorno
deps: upgrade npm to 7.18.1
98139df 
PR-URL: #39065
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@ruyadorno
Copy link
Member

Landed in 98139df

@ruyadorno ruyadorno closed this Jun 18, 2021
danielleadams pushed a commit that referenced this pull request Jun 21, 2021
@npm-robot @danielleadams
deps: upgrade npm to 7.18.1
1fa724e 
PR-URL: #39065
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@danielleadams danielleadams mentioned this pull request Jun 21, 2021
Merged
danielleadams added a commit that referenced this pull request Jun 21, 2021
@danielleadams
2021-06-22, Version 16.4.0 (Current)
a5508f5 
Notable changes:

* deps:
  * upgrade npm to 7.18.1 (npm-robot) #39065
  * update V8 to 9.1.269.36 (Michaël Zasso) #38273
* dns:
  * allow `--dns-result-order` to change default dns verbatim (Ouyang Yadong) #38099
danielleadams added a commit that referenced this pull request Jun 21, 2021
@danielleadams
2021-06-22, Version 16.4.0 (Current)
6c62d69 
Notable changes:

* deps:
  * upgrade npm to 7.18.1 (npm-robot) #39065
  * update V8 to 9.1.269.36 (Michaël Zasso) #38273
* dns:
  * allow `--dns-result-order` to change default dns verbatim (Ouyang Yadong) #38099
danielleadams added a commit that referenced this pull request Jun 22, 2021
@danielleadams
2021-06-22, Version 16.4.0 (Current)
75a7dd9 
Notable changes:

* deps:
  * upgrade npm to 7.18.1 (npm-robot) #39065
  * update V8 to 9.1.269.36 (Michaël Zasso) #38273
* dns:
  * allow `--dns-result-order` to change default dns verbatim (Ouyang Yadong) #38099
danielleadams added a commit that referenced this pull request Jun 22, 2021
@danielleadams
2021-06-22, Version 16.4.0 (Current)
6e6f9d0 
Notable changes:

* async_hooks:
  * stabilize part of AsyncLocalStorage (Vladimir de Turckheim) #37675
* deps:
  * upgrade npm to 7.18.1 (npm-robot) #39065
  * update V8 to 9.1.269.36 (Michaël Zasso) #38273
* dns:
  * allow `--dns-result-order` to change default dns verbatim (Ouyang Yadong) #38099
danielleadams added a commit that referenced this pull request Jun 22, 2021
@danielleadams
2021-06-22, Version 16.4.0 (Current)
8a19b2b 
PR-URL: #39031

Notable changes:

* async_hooks:
  * stabilize part of AsyncLocalStorage (Vladimir de Turckheim) #37675
* deps:
  * upgrade npm to 7.18.1 (npm-robot) #39065
  * update V8 to 9.1.269.36 (Michaël Zasso) #38273
* dns:
  * allow `--dns-result-order` to change default dns verbatim (Ouyang Yadong) #38099
danielleadams added a commit that referenced this pull request Jun 22, 2021
@danielleadams
2021-06-22, Version 16.4.0 (Current)
c537f5f 
Notable changes:

* async_hooks:
  * stabilize part of AsyncLocalStorage (Vladimir de Turckheim) #37675
* deps:
  * upgrade npm to 7.18.1 (npm-robot) #39065
  * update V8 to 9.1.269.36 (Michaël Zasso) #38273
* dns:
  * allow `--dns-result-order` to change default dns verbatim (Ouyang Yadong) #38099

PR-URL: #39031
danielleadams added a commit that referenced this pull request Jun 23, 2021
@danielleadams
2021-06-23, Version 16.4.0 (Current)
4b2085f 
Notable changes:

* async_hooks:
  * stabilize part of AsyncLocalStorage (Vladimir de Turckheim) #37675
* deps:
  * upgrade npm to 7.18.1 (npm-robot) #39065
  * update V8 to 9.1.269.36 (Michaël Zasso) #38273
* dns:
  * allow `--dns-result-order` to change default dns verbatim (Ouyang Yadong) #38099

PR-URL: #39031
danielleadams added a commit that referenced this pull request Jun 23, 2021
@danielleadams
2021-06-23, Version 16.4.0 (Current)
84d6ce9 
Notable changes:

* async_hooks:
  * stabilize part of AsyncLocalStorage (Vladimir de Turckheim) #37675
* deps:
  * upgrade npm to 7.18.1 (npm-robot) #39065
  * update V8 to 9.1.269.36 (Michaël Zasso) #38273
* dns:
  * allow `--dns-result-order` to change default dns verbatim (Ouyang Yadong) #38099

PR-URL: #39031
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

@ruyadorno ruyadorno ruyadorno approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@npm-robot @wraithgar @lpinca @nodejs-github-bot @ruyadorno @MylesBorins @cjihrig