Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add missing changelog links #39016

Closed
wants to merge 2 commits into from
Closed

doc: add missing changelog links #39016

wants to merge 2 commits into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jun 12, 2021

Refs: #38507
Refs: #38874

@github-actions github-actions bot added the meta Issues and PRs related to the general management of the project. label Jun 12, 2021
@aduh95 aduh95 added doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. and removed meta Issues and PRs related to the general management of the project. labels Jun 12, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@aduh95 aduh95 mentioned this pull request Jun 12, 2021
Merged
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. meta Issues and PRs related to the general management of the project. labels Jun 13, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 13, 2021
@github-actions
Copy link
Contributor

Landed in 423ae41...174b191

@github-actions github-actions bot closed this Jun 13, 2021
nodejs-github-bot pushed a commit that referenced this pull request Jun 13, 2021
@aduh95 @nodejs-github-bot
doc: add missing changelog links
174b191 
Refs: #38507
Refs: #38874

PR-URL: #39016
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
danielleadams pushed a commit that referenced this pull request Jun 13, 2021
@aduh95 @danielleadams
doc: add missing changelog links
51561f3 
Refs: #38507
Refs: #38874

PR-URL: #39016
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
@aduh95 aduh95 deleted the fix-changelog branch June 13, 2021 07:29
@danielleadams danielleadams mentioned this pull request Jun 14, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jun 17, 2021
@aduh95 @danielleadams
doc: add missing changelog links
c5399ca 
Refs: #38507
Refs: #38874

PR-URL: #39016
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lxxyx Lxxyx Lxxyx approved these changes

@richardlau richardlau richardlau approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aduh95 @Trott @lpinca @targos @richardlau @Lxxyx