Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade npm to 7.16.0 #38920

Closed
wants to merge 1 commit into from
Closed

deps: upgrade npm to 7.16.0 #38920

wants to merge 1 commit into from

Conversation

npm-robot
Copy link
Contributor

v7.16.0 (2021-06-03)

FEATURES

BUG FIXES

DOCUMENTATION

DEPENDENCIES

  • 54de5c6a4 [email protected]:
    • fix: trim whitespace from fetchSpec
    • fix: handle file: when root directory begins with a special character
  • e92b5f2ba [email protected]
    • breaking: complete refactor of caching. drops warning headers, prevents cache indexes from growing for every request, correctly handles varied requests to the same url, and now caches redirects.
    • fix: support url-encoded proxy authorization
    • fix: do not lazy-load proxy agents or agentkeepalive. fixes the intermittent failures to update npm on slower connections. [email protected]
    • breaking: drop handling of deprecated warning headers
    • docs: fix header type for npm-command
    • docs: update registry param
    • feat: improved logging of cache status
  • 23c50a45f [email protected]:
    • fix: work around negotiator's lazy loading

AUTOMATION

@github-actions github-actions bot added needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry. labels Jun 3, 2021
@bl-ue
Copy link
Contributor

bl-ue commented Jun 3, 2021

Hey @ruyadorno — if you don't like that every time @npm-robot updates npm here, it references a lot of npm PRs, causing a "this pull request was referenced ..." timeline event on those PRs, you could make @npm-robot mimic Dependabot and intercept issue/PR #'s and replace them with https://github-redirect.dependabot.com.

For example: https://github-redirect.dependabot.com/npm/cli/issues/3345

bl-ue
bl-ue approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not too large a diff 🎉

@ruyadorno
Copy link
Member

Hey @ruyadorno — if you don't like that every time @npm-robot updates npm here, it references a lot of npm PRs, causing a "this pull request was referenced ..." timeline event on those PRs, you could make @npm-robot mimic Dependabot and intercept issue/PR #'s and replace them with https://github-redirect.dependabot.com.

For example: https://github-redirect.dependabot.com/npm/cli/issues/3345

awesome, that's good to know! thanks @bl-ue

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38539/

@MylesBorins MylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 8, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2021

Fast-track has been requested by @MylesBorins. Please 👍 to approve.

@ruyadorno
Copy link
Member

oh no need to fast-track @MylesBorins, it has been open for almost a week now 😅

I'm actually landing it! thanks!

ruyadorno pushed a commit that referenced this pull request Jun 8, 2021
@npm-robot @ruyadorno
deps: upgrade npm to 7.16.0
306a57d 
PR-URL: #38920
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@ruyadorno
Copy link
Member

Landed in 306a57d

@ruyadorno ruyadorno closed this Jun 8, 2021
targos pushed a commit that referenced this pull request Jun 11, 2021
@npm-robot @targos
deps: upgrade npm to 7.16.0
70af146 
PR-URL: #38920
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@danielleadams danielleadams mentioned this pull request Jun 14, 2021
Merged
@bl-ue
Copy link
Contributor

bl-ue commented Jun 18, 2021

@ruyadorno I'd like to tell you: my note about dependabot, while correct and cool, isn't the best way. The best way that I know of to reference and issue or PR without actually notifing that issue or PR is to use www.github.com instead of github.com in the URL. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruyadorno ruyadorno ruyadorno approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

@bl-ue bl-ue bl-ue approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@npm-robot @bl-ue @ruyadorno @nodejs-github-bot @MylesBorins @targos