Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: use missing validators #38893

Closed
wants to merge 4 commits into from
Closed

util: use missing validators #38893

wants to merge 4 commits into from

Commits on Jun 1, 2021

  1. util: use missing validators 

    The `inherits()` method in the `util` lib module is not using validators which others do use.
    @VoltrexKeyva
    VoltrexKeyva committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    dda5e5f View commit details
    Browse the repository at this point in the history

  2. fixup! remove unused error constructor 

    Removed the `ERR_INVALID_ARG_TYPE` constructor which was only used in the `inherits()` method which is replaced now.
    @VoltrexKeyva
    VoltrexKeyva committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    5ed5519 View commit details
    Browse the repository at this point in the history

  3. fixup! pass valid test value 

    The value must be a function to test the type of the prototype since validators first check if the value is a function.
    @VoltrexKeyva
    VoltrexKeyva committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    43c4491 View commit details
    Browse the repository at this point in the history

  4. fixup! prototype test value 

    The message expects to fail with the value `undefined`, not `null`.
    @VoltrexKeyva
    VoltrexKeyva committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    80b1d81 View commit details
    Browse the repository at this point in the history