Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: set PromiseHooks by Environment #38821

Closed
wants to merge 8 commits into from
Closed

src: set PromiseHooks by Environment #38821

wants to merge 8 commits into from

Commits on May 26, 2021

  1. src: set PromiseHooks by Environment 

    The new JS PromiseHooks introduced in the referenced PR are per
v8::Context. This meant that code depending on them, such as
AsyncLocalStorage, wouldn't behave correctly across vm.Context
instances.

PromiseHooks are now synchronized across the main Context and any
Context created via vm.Context.

Refs: nodejs#36394
Fixes: nodejs#38781
Signed-off-by: Bryan English <[email protected]>
    @bengl
    bengl committed May 26, 2021
    Configuration menu
    Copy the full SHA
    7986a9b View commit details
    Browse the repository at this point in the history

Commits on May 27, 2021

  1. fixup! switch to weak globals

    @bengl
    bengl committed May 27, 2021
    Configuration menu
    Copy the full SHA
    bb55976 View commit details
    Browse the repository at this point in the history

  2. fixup! switch to weak globals for hook functions

    @bengl
    bengl committed May 27, 2021
    Configuration menu
    Copy the full SHA
    0f4342b View commit details
    Browse the repository at this point in the history

Commits on May 28, 2021

  1. fixup! Revert "fixup! switch to weak globals for hook functions" 

    This reverts commit 0f4342b.
    @bengl
    bengl committed May 28, 2021
    Configuration menu
    Copy the full SHA
    d1667ad View commit details
    Browse the repository at this point in the history

  2. fixup! switch accidental strong ref, and use handle scopes

    @bengl
    bengl committed May 28, 2021
    Configuration menu
    Copy the full SHA
    d3ec54a View commit details
    Browse the repository at this point in the history

Commits on May 31, 2021

  1. fixup! review nits and AsyncHooks::MemoryInfo

    @bengl
    bengl committed May 31, 2021
    Configuration menu
    Copy the full SHA
    add2360 View commit details
    Browse the repository at this point in the history

  2. fixup! correct MemoryInfo

    @bengl
    bengl committed May 31, 2021
    Configuration menu
    Copy the full SHA
    a968969 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2021

  1. fixup! add checks for snapshot

    @bengl
    bengl committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    5ea90f7 View commit details
    Browse the repository at this point in the history