Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: stop fixing EPERM on Windows #38810

Closed
wants to merge 20 commits into from
Closed

fs: stop fixing EPERM on Windows #38810

wants to merge 20 commits into from

Commits on Jun 2, 2021

  1. fs: stop fixing EPERM on Windows 

    Originally, when rimraf faced an EPERM on Windows, it would try to
change the file permissions of the entry and attempt to remove it
again. However, rm -rf doesn't change any file permissions, so rimraf
shouldn't either.

This change also updates test/common/tmpdir.js to repeatedly try
changing the file permissions of its contents to 0o777 when an EACCES or
an EPERM is faced while attempting to remove them.

Signed-off-by: Darshan Sen <[email protected]>
    @RaisinTen
    RaisinTen committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    8186ba4 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2021

  1. move checks into functions

    @RaisinTen
    RaisinTen committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    abdadd3 View commit details
    Browse the repository at this point in the history

  2. reindent

    @RaisinTen
    RaisinTen committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    ea8e0a5 View commit details
    Browse the repository at this point in the history

  3. update comments

    @RaisinTen
    RaisinTen committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    9596fdc View commit details
    Browse the repository at this point in the history

  4. tmpdir: remove empty call

    @RaisinTen
    RaisinTen committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    8975f3e View commit details
    Browse the repository at this point in the history

  5. fixup! tmpdir: remove empty call

    @RaisinTen
    RaisinTen committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    aedf3a9 View commit details
    Browse the repository at this point in the history

  6. lint fix

    @RaisinTen
    RaisinTen committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    838cad0 View commit details
    Browse the repository at this point in the history

  7. Apply suggestions from code review 

    Co-authored-by: Antoine du Hamel <[email protected]>
    @RaisinTen @aduh95
    RaisinTen and aduh95 committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    ecac8c6 View commit details
    Browse the repository at this point in the history

  8. Apply suggestions from code review

    @RaisinTen
    RaisinTen committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    f48b819 View commit details
    Browse the repository at this point in the history

  9. Apply suggestions from code review 

    Co-authored-by: Antoine du Hamel <[email protected]>
    @RaisinTen @aduh95
    RaisinTen and aduh95 committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    f67b959 View commit details
    Browse the repository at this point in the history

  10. lint fix

    @RaisinTen
    RaisinTen committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    d4e6c6e View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Antoine du Hamel <[email protected]>
    @RaisinTen @aduh95
    RaisinTen and aduh95 committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    3e52248 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review

    @RaisinTen
    RaisinTen committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    bd817e2 View commit details
    Browse the repository at this point in the history

  3. tmpdir: remove if around throw err

    @RaisinTen
    RaisinTen committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    d0173e5 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Antoine du Hamel <[email protected]>
    @RaisinTen @aduh95
    RaisinTen and aduh95 committed Jun 5, 2021
    Configuration menu
    Copy the full SHA
    e88bdbb View commit details
    Browse the repository at this point in the history

  2. tmpdir: inline error logging function

    @RaisinTen
    RaisinTen committed Jun 5, 2021
    Configuration menu
    Copy the full SHA
    a766a75 View commit details
    Browse the repository at this point in the history

  3. use InvalidStateError class

    @RaisinTen
    RaisinTen committed Jun 5, 2021
    Configuration menu
    Copy the full SHA
    8c76097 View commit details
    Browse the repository at this point in the history

  4. isValidState -> validateState

    @RaisinTen
    RaisinTen committed Jun 5, 2021
    Configuration menu
    Copy the full SHA
    65657f2 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2021

  1. log error from tmpdir only once at max

    @RaisinTen
    RaisinTen committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    befac4b View commit details
    Browse the repository at this point in the history

  2. ||= ~> if

    @RaisinTen
    RaisinTen committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    3fe174f View commit details
    Browse the repository at this point in the history