Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

child_process: retain reference to data with advanced serialization #38728

Closed
wants to merge 1 commit into from
Closed

child_process: retain reference to data with advanced serialization #38728

wants to merge 1 commit into from

Commits on May 18, 2021

  1. child_process: retain reference to data with advanced serialization 

    Do the same thing we do for other streams, and retain a reference to
the Buffer that was sent over IPC while the write request is active,
so that it doesn’t get garbage collected while the data is still in
flight.

(This is a good example of why it’s a bad idea that we’re not re-using
the general streams implementation for IPC and instead maintain
separate usage of the low-level I/O primitives.)

Fixes: nodejs#34797
    @addaleax
    addaleax committed May 18, 2021
    Configuration menu
    Copy the full SHA
    b91474c View commit details
    Browse the repository at this point in the history