Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v14.x backport] lib: make safe primordials safe to iterate #38703

Closed

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented May 16, 2021

Backport PR to remove the logical nullish assignment operator (not supported until V8 8.5).

PR-URL: #36391
Reviewed-By: Michaël Zasso [email protected]
Reviewed-By: James M Snell [email protected]

@aduh95 aduh95 added the v14.x label May 16, 2021
@aduh95 aduh95 requested a review from targos May 16, 2021 15:57
@github-actions github-actions bot added needs-ci PRs that need a full CI run. worker Issues and PRs related to Worker support. labels May 16, 2021
PR-URL: nodejs#36391
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@aduh95 aduh95 force-pushed the backport-safe-primordials-iterable branch from affd0c8 to 7f16442 Compare May 16, 2021 19:08
@targos targos changed the title lib: make safe primordials safe to iterate [v14.x backport] lib: make safe primordials safe to iterate May 16, 2021
targos pushed a commit that referenced this pull request May 25, 2021
PR-URL: #36391
Backport-PR-URL: #38703
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos
Copy link
Member

targos commented May 25, 2021

Landed in e108be0

@targos targos closed this May 25, 2021
targos pushed a commit that referenced this pull request Jun 5, 2021
PR-URL: #36391
Backport-PR-URL: #38703
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jun 11, 2021
PR-URL: #36391
Backport-PR-URL: #38703
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. worker Issues and PRs related to Worker support.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants