Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v14.x]: deps: V8: Add Power9/10 to the supported list and enable related features #38508

Closed
wants to merge 2 commits into from

Conversation

miladfarca
Copy link
Contributor

Please note that enum values are slightly different from V8 upstream, i.e PPC_POWER10 instead of kPPCPower10.
Power 9 is also added to some of the features within the ppc assembler, this is to make adding P10 consistent and is not part of the original CL on V8.
We have SIMD enabled upstream which will not be backported here.

Refs: v8/v8@530080c

@github-actions github-actions bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v14.x v8 engine Issues and PRs related to the V8 dependency. labels May 3, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 3, 2021

@aduh95 aduh95 changed the title deps: V8: Add Power9/10 to the supported list and enable related features [v14.x]: deps: V8: Add Power9/10 to the supported list and enable related features May 3, 2021
@miladfarca miladfarca requested review from targos and richardlau and removed request for targos May 3, 2021 13:05
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 14, 2021

@miladfarca
Copy link
Contributor Author

miladfarca commented May 14, 2021

@richardlau Similar to #38509, I don't think I will be able to land this on my own either.

@richardlau
Copy link
Member

Yes, only members of the backporters and/or release team can land on the staging branches. I'll land this if the CI's currently in progress pass.

richardlau pushed a commit that referenced this pull request May 14, 2021
Original commit message:
    ```
    PPC: Add Power10 to the supported list and enable related features

    This CL adds Power10 recognition to Linux, AIX as well as IBMi.

    Enabled features include:
    MODULO
    FPR_GPR_MOV
    SIMD
    LWSYNC
    ISELECT
    VSX

    Change-Id: Ifc337e6497a3efe9697bcf03063a2b94471f96e9
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2855041
    Reviewed-by: Clemens Backes <[email protected]>
    Reviewed-by: Junliang Yan <[email protected]>
    Reviewed-by: Vasili Skurydzin <[email protected]>
    Commit-Queue: Milad Fa <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#74279}
    ```

Refs: v8/v8@530080c

PR-URL: #38508
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@richardlau
Copy link
Member

Landed in d678277.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants