Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: move test-net-connect-econnrefused from pummel to sequential #38462

Merged
merged 1 commit into from
May 4, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 29, 2021

test-net-connect-econnrefused esems to run quickly on all platforms and
does not appear to need to be in the pummel directory. Move to
sequential.

@github-actions github-actions bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 29, 2021
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

@lpinca
Copy link
Member

lpinca commented May 1, 2021

"esems" -> "seems" typo in commit message.

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

test-net-connect-econnrefused esems to run quickly on all platforms and
does not appear to need to be in the pummel directory. Move to
sequential.

PR-URL: nodejs#38462
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@Trott
Copy link
Member Author

Trott commented May 4, 2021

Landed in df3465a

@Trott Trott merged commit df3465a into nodejs:master May 4, 2021
@Trott Trott deleted the econ branch May 4, 2021 12:58
targos pushed a commit that referenced this pull request May 17, 2021
test-net-connect-econnrefused esems to run quickly on all platforms and
does not appear to need to be in the pummel directory. Move to
sequential.

PR-URL: #38462
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request May 30, 2021
test-net-connect-econnrefused esems to run quickly on all platforms and
does not appear to need to be in the pummel directory. Move to
sequential.

PR-URL: #38462
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Jun 5, 2021
test-net-connect-econnrefused esems to run quickly on all platforms and
does not appear to need to be in the pummel directory. Move to
sequential.

PR-URL: #38462
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Jun 5, 2021
test-net-connect-econnrefused esems to run quickly on all platforms and
does not appear to need to be in the pummel directory. Move to
sequential.

PR-URL: #38462
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Jun 11, 2021
test-net-connect-econnrefused esems to run quickly on all platforms and
does not appear to need to be in the pummel directory. Move to
sequential.

PR-URL: #38462
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants