Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update ESLint to 7.25.0 #38378

Closed
wants to merge 2 commits into from
Closed

tools: update ESLint to 7.25.0 #38378

wants to merge 2 commits into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Apr 24, 2021

Update ESLint to 7.25.0

Update ESLint to 7.25.0
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Apr 24, 2021
@aduh95
Copy link
Contributor

aduh95 commented Apr 24, 2021

The update is causing a linter failure on test/parallel/test-tls-transport-destroy-after-own-gc.js 🤔

@targos
Copy link
Member

targos commented Apr 24, 2021

It looks like we need to move the disable comment to where the variable is defined.

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 24, 2021
jasnell pushed a commit that referenced this pull request Apr 26, 2021
Update ESLint to 7.25.0

PR-URL: #38378
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Apr 26, 2021

Landed in 59db84a

@jasnell jasnell closed this Apr 26, 2021
@cjihrig cjihrig deleted the eslint branch April 26, 2021 19:02
targos pushed a commit that referenced this pull request Apr 29, 2021
Update ESLint to 7.25.0

PR-URL: #38378
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request May 3, 2021
targos pushed a commit that referenced this pull request May 30, 2021
Update ESLint to 7.25.0

PR-URL: #38378
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jun 5, 2021
Update ESLint to 7.25.0

PR-URL: #38378
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jun 5, 2021
Update ESLint to 7.25.0

PR-URL: #38378
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jun 11, 2021
Update ESLint to 7.25.0

PR-URL: #38378
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants