Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: clarify DiffieHellmanGroup class docs #38363

Closed
wants to merge 2 commits into from

Conversation

Linkgoron
Copy link
Member

@Linkgoron Linkgoron commented Apr 22, 2021

Make it clearer in the docs that DiffieHellmanGroup does not support changing the keys after creation (it's already mentioned in the docs - but only in the documentation for the getDiffieHellman method).

Make it clearer in the docs that DiffieHellmanGroup does
not support changing the keys after creation.
@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Apr 22, 2021
Copy link

@CertifiedRice CertifiedRice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eh, I would just keep the deleted lines you deleted.
the new 4 lines isn't nessceary

doc/api/crypto.md Outdated Show resolved Hide resolved
doc/api/crypto.md Outdated Show resolved Hide resolved
doc/api/crypto.md Outdated Show resolved Hide resolved
doc/api/crypto.md Outdated Show resolved Hide resolved
@jasnell
Copy link
Member

jasnell commented May 4, 2021

Landed in 9643128

jasnell pushed a commit that referenced this pull request May 4, 2021
Make it clearer in the docs that DiffieHellmanGroup does
not support changing the keys after creation.

PR-URL: #38363
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Adrian Estrada <[email protected]>
@jasnell jasnell closed this May 4, 2021
targos pushed a commit that referenced this pull request May 17, 2021
Make it clearer in the docs that DiffieHellmanGroup does
not support changing the keys after creation.

PR-URL: #38363
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Adrian Estrada <[email protected]>
targos pushed a commit that referenced this pull request May 30, 2021
Make it clearer in the docs that DiffieHellmanGroup does
not support changing the keys after creation.

PR-URL: #38363
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Adrian Estrada <[email protected]>
targos pushed a commit that referenced this pull request Jun 5, 2021
Make it clearer in the docs that DiffieHellmanGroup does
not support changing the keys after creation.

PR-URL: #38363
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Adrian Estrada <[email protected]>
targos pushed a commit that referenced this pull request Jun 5, 2021
Make it clearer in the docs that DiffieHellmanGroup does
not support changing the keys after creation.

PR-URL: #38363
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Adrian Estrada <[email protected]>
targos pushed a commit that referenced this pull request Jun 11, 2021
Make it clearer in the docs that DiffieHellmanGroup does
not support changing the keys after creation.

PR-URL: #38363
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Adrian Estrada <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants