lib/path: Add JSDoc Types #38186
Closed
lib/path: Add JSDoc Types #38186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
|
I hope this PR and #38185 are of help. Let me know if I need to change anything :) |
Ayase-252
reviewed
Apr 10, 2021
|
Hi, @Skn0tt It seems there are still some errors from linters, would you mind fix them? You can also run linters locally to detect linting problem by |
targos
reviewed
Apr 13, 2021
targos
approved these changes
Apr 14, 2021
targos
force-pushed
the
path-jsdoc-types
branch
from
161c036 to
7adcd94
Compare
targos
pushed a commit
that referenced
this pull request
Apr 14, 2021
PR-URL: #38186 Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
|
Landed in f1a21e5. Thanks for the contribution! |
BethGriggs
pushed a commit
that referenced
this pull request
Apr 15, 2021
PR-URL: #38186 Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
PR-URL: #38186 Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Merged
danielleadams
pushed a commit
that referenced
this pull request
May 8, 2021
PR-URL: #38186 Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by @bmeck: https://twitter.com/bradleymeck/status/1380643627211354115
Changes based on https://nodejs.org/dist/latest-v14.x/docs/api/path.html#path_path_delimiter.