test: fix flaky test-zlib-unused-weak.js #38149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
richardlau
approved these changes
Apr 8, 2021
jasnell
approved these changes
Apr 8, 2021
addaleax
approved these changes
Apr 8, 2021
richardlau
added
the
author ready
lpinca
approved these changes
Apr 9, 2021
|
Fast-track? |
|
+1 to fast track |
oyyd
added a commit
that referenced
this pull request
Apr 9, 2021
PR-URL: #38149 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
|
Landed in f96dffb, thanks! |
targos
pushed a commit
that referenced
this pull request
May 1, 2021
PR-URL: #38149 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Merged
danielleadams
pushed a commit
that referenced
this pull request
May 8, 2021
PR-URL: #38149 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failed test: https://ci.nodejs.org/job/node-test-commit-linux/nodes=alpine-last-latest-x64/40825/testReport/junit/(root)/test/parallel_test_zlib_unused_weak/
I think the delta should be positive. Calling
gc()beforezlib.createGzip()should make it more stable.