Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add link to V8 #38144

Closed
wants to merge 3 commits into from
Closed

doc: add link to V8 #38144

wants to merge 3 commits into from

Conversation

VoltrexKeyva
Copy link
Member

@VoltrexKeyva VoltrexKeyva commented Apr 8, 2021

Added the link redirecting to the V8 engine main domain just like libuv.

Added the link redirecting to the V8 engine github repository just like libuv.
@nodejs-github-bot nodejs-github-bot added addons Issues and PRs related to native addons. doc Issues and PRs related to the documentations. labels Apr 8, 2021
V8 should be above Worker.
@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 8, 2021
doc/api/addons.md Outdated Show resolved Hide resolved
V8 redirect URL should redirect to the google source original domain instead of the mirror.
RaisinTen pushed a commit that referenced this pull request Apr 10, 2021
Added the link redirecting to the V8 engine github repository just like
libuv.

PR-URL: #38144
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@RaisinTen
Copy link
Contributor

Landed in 6a2314a

@RaisinTen RaisinTen closed this Apr 10, 2021
@VoltrexKeyva VoltrexKeyva deleted the patch-2 branch April 17, 2021 03:08
targos pushed a commit that referenced this pull request May 1, 2021
Added the link redirecting to the V8 engine github repository just like
libuv.

PR-URL: #38144
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
danielleadams pushed a commit that referenced this pull request May 8, 2021
Added the link redirecting to the V8 engine github repository just like
libuv.

PR-URL: #38144
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addons Issues and PRs related to native addons. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants