test: remove unneeded m flag on regular expressions #38124
Merged
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
Trott
changed the title
aduh95
approved these changes
Apr 7, 2021
aduh95
added
the
author ready
lpinca
approved these changes
Apr 7, 2021
RaisinTen
approved these changes
Apr 7, 2021
jasnell
approved these changes
Apr 7, 2021
addaleax
approved these changes
Apr 7, 2021
cjihrig
approved these changes
Apr 8, 2021
The m flag has no effect on regular expressions that don't match the start or the end of a line. PR-URL: nodejs#38124 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
Landed in 7e516aa |
targos
pushed a commit
that referenced
this pull request
May 1, 2021
The m flag has no effect on regular expressions that don't match the start or the end of a line. PR-URL: #38124 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
danielleadams
pushed a commit
that referenced
this pull request
May 8, 2021
The m flag has no effect on regular expressions that don't match the start or the end of a line. PR-URL: #38124 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The m flag has no effect on regular expressions that don't match the
start or the end of a line.