Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process: do not lazily load AsyncResource #38041

Closed
wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Apr 2, 2021

It doesn't seem necessary.

It doesn't seem necessary.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. labels Apr 2, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 3, 2021

@Flarna Flarna added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 3, 2021
@jasnell
Copy link
Member

jasnell commented Apr 6, 2021

Landed in 8dd5dd8

@jasnell jasnell closed this Apr 6, 2021
jasnell pushed a commit that referenced this pull request Apr 6, 2021
It doesn't seem necessary.

PR-URL: #38041
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos deleted the no-lazy-async-resource branch April 7, 2021 05:48
targos added a commit that referenced this pull request May 1, 2021
It doesn't seem necessary.

PR-URL: #38041
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants