Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: package release changelog for releases #38033

Closed
wants to merge 1 commit into from

Conversation

richardlau
Copy link
Member

Package the changelog for the release line as CHANGELOG.md when
building a release binary tarball.

Fixes: #38025

cc @nodejs/releasers

Package the changelog for the release line as `CHANGELOG.md` when
building a release binary tarball.
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Apr 2, 2021
@nodejs-github-bot

This comment has been minimized.

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 6, 2021
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

@jasnell
Copy link
Member

jasnell commented Apr 7, 2021

Landed in 9cfb418

@jasnell jasnell closed this Apr 7, 2021
jasnell pushed a commit that referenced this pull request Apr 7, 2021
Package the changelog for the release line as `CHANGELOG.md` when
building a release binary tarball.

PR-URL: #38033
Fixes: #38025
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request May 1, 2021
Package the changelog for the release line as `CHANGELOG.md` when
building a release binary tarball.

PR-URL: #38033
Fixes: #38025
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

distributed CHANGELOG is useless
8 participants