Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: fix chown abort #38004

Closed
wants to merge 5 commits into from
Closed

fs: fix chown abort #38004

wants to merge 5 commits into from

Commits on Mar 31, 2021

  1. fs: fix chown abort 

    This syncs the type assertion introduced in the referenced PR in the C++
side. Since chown, lchown, and fchown can accept -1 as a value for uid
and gid, we should also accept signed integers from the JS side.

Fixes: nodejs#37995
Refs: nodejs#31694
    @RaisinTen
    RaisinTen committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    5402b26 View commit details
    Browse the repository at this point in the history

  2. fixup! fs: fix chown abort

    @RaisinTen
    RaisinTen committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    0c5fea2 View commit details
    Browse the repository at this point in the history

  3. update validation in fs promises

    @RaisinTen
    RaisinTen committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    d9c96b6 View commit details
    Browse the repository at this point in the history

  4. fixup! update validation in fs promises

    @RaisinTen
    RaisinTen committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    97e3d0c View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2021

  1. fixup! update validation in fs promises

    @RaisinTen
    RaisinTen committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    9749f64 View commit details
    Browse the repository at this point in the history