Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v14.x] deps: update to [email protected] #38002

Closed

Conversation

guybedford
Copy link
Contributor

This backports the cjs-module-lexer update from #37992 for 14.x.

Note this branch didn't get the 1.1.0 update yet, so this handles the full upgrade path.

@nodejs/modules

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v14.x labels Mar 31, 2021
@nodejs-github-bot
Copy link
Collaborator

@guybedford guybedford force-pushed the cjs-module-lexer-update-14 branch from 884fc07 to efcad79 Compare April 8, 2021 14:34
@nodejs-github-bot
Copy link
Collaborator

Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@guybedford guybedford changed the base branch from v14.x-staging to v14.x April 8, 2021 22:48
@guybedford guybedford changed the base branch from v14.x to v14.x-staging April 8, 2021 22:53
guybedford added a commit that referenced this pull request Apr 14, 2021
PR-URL: #38002
Backport-PR-URL: #37992
Reviewed-By: Jan Krems <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@guybedford
Copy link
Contributor Author

Landed in d56079a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants