Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: deflake test-fs-read-optional-params #37991

Closed
wants to merge 1 commit into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Mar 30, 2021

If fs.read() is called without specifying the position option, data
will be read from the current file position. There is another concurrent
fs.read() call before the test for no options object which might
invalidate the test expectations.

Run the test for no options object first.

Fixes: #37946

If `fs.read()` is called without specifying the `position` option, data
will be read from the current file position. There is another concurrent
`fs.read()` call before the test for no options object which might
invalidate the test expectations.

Run the test for no options object first.

Fixes: nodejs#37946
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 30, 2021
@lpinca
Copy link
Member Author

lpinca commented Mar 30, 2021

This seems to fix the issue on my Windows machine.

cc: @nodejs/fs

@nodejs-github-bot
Copy link
Collaborator

lpinca added a commit that referenced this pull request Apr 3, 2021
If `fs.read()` is called without specifying the `position` option, data
will be read from the current file position. There is another concurrent
`fs.read()` call before the test for no options object which might
invalidate the test expectations.

Run the test for no options object first.

PR-URL: #37991
Fixes: #37946
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@lpinca
Copy link
Member Author

lpinca commented Apr 3, 2021

Landed in fae0320.

@lpinca lpinca closed this Apr 3, 2021
@lpinca lpinca deleted the fix/issue-37946 branch April 3, 2021 05:23
MylesBorins pushed a commit that referenced this pull request Apr 4, 2021
If `fs.read()` is called without specifying the `position` option, data
will be read from the current file position. There is another concurrent
`fs.read()` call before the test for no options object which might
invalidate the test expectations.

Run the test for no options object first.

PR-URL: #37991
Fixes: #37946
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 4, 2021
MylesBorins pushed a commit that referenced this pull request Apr 5, 2021
If `fs.read()` is called without specifying the `position` option, data
will be read from the current file position. There is another concurrent
`fs.read()` call before the test for no options object which might
invalidate the test expectations.

Run the test for no options object first.

PR-URL: #37991
Fixes: #37946
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
targos pushed a commit that referenced this pull request May 1, 2021
If `fs.read()` is called without specifying the `position` option, data
will be read from the current file position. There is another concurrent
`fs.read()` call before the test for no options object which might
invalidate the test expectations.

Run the test for no options object first.

PR-URL: #37991
Fixes: #37946
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

investigate flaky test-fs-read-optional-params
7 participants