Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readline: add Promise-based API #37947

Closed
wants to merge 4 commits into from
Closed

readline: add Promise-based API #37947

wants to merge 4 commits into from

Commits on Sep 16, 2021

  1. readline: refactor Interface to ES2015 class 

    PR-URL: nodejs#37947
Fixes: nodejs#37287
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
    @aduh95
    aduh95 committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    592d1c3 View commit details
    Browse the repository at this point in the history

  2. readline: introduce promise-based API 

    PR-URL: nodejs#37947
Fixes: nodejs#37287
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
    @aduh95
    aduh95 committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    8122d24 View commit details
    Browse the repository at this point in the history

  3. readline: validate AbortSignals and remove unused event listeners 

    PR-URL: nodejs#37947
Fixes: nodejs#37287
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
    @aduh95
    aduh95 committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    707dd77 View commit details
    Browse the repository at this point in the history

  4. readline: add autoCommit option 

    PR-URL: nodejs#37947
Fixes: nodejs#37287
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
    @aduh95
    aduh95 committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    341312d View commit details
    Browse the repository at this point in the history