Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: use sentence-style capitlaztion in template header #37837

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 20, 2021

Make the level one header for all the HTML documents use consistent
capitalization style as the documentation itself.

Without this change:

image

With this change::

image

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 20, 2021
Make the level one header for all the HTML documents use consistent
capitalization style as the documentation itself.

PR-URL: nodejs#37837
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@Trott
Copy link
Member Author

Trott commented Mar 22, 2021

Landed in 172a09f

@Trott Trott merged commit 172a09f into nodejs:master Mar 22, 2021
@Trott Trott deleted the level-1 branch March 22, 2021 13:59
ruyadorno pushed a commit that referenced this pull request Mar 24, 2021
Make the level one header for all the HTML documents use consistent
capitalization style as the documentation itself.

PR-URL: #37837
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Mar 30, 2021
targos pushed a commit that referenced this pull request May 1, 2021
Make the level one header for all the HTML documents use consistent
capitalization style as the documentation itself.

PR-URL: #37837
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants