Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove references to unsupported AIX versions #37826

Closed
wants to merge 1 commit into from
Closed

test: remove references to unsupported AIX versions #37826

wants to merge 1 commit into from

Conversation

richardlau
Copy link
Member

@richardlau richardlau commented Mar 20, 2021 •
edited
Loading

The filehandle.utimes() and fs.futimes() APIs work on all versions
of AIX that are supported by this version of Node.js.

cc @nodejs/platform-aix

@richardlau richardlau added the aix Issues and PRs related to the AIX platform. label Mar 20, 2021
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 20, 2021
@richardlau richardlau added test Issues and PRs related to the tests. doc Issues and PRs related to the documentations. labels Mar 20, 2021
sxa
sxa approved these changes Mar 20, 2021
View reviewed changes
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I doubt there are many people trying to use it on earlier versions now that are likely to complain :-)

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 20, 2021 •
edited by richardlau
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/36884/
IBM i: https://ci.nodejs.org/job/node-test-commit-ibmi/306/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36888/

@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 21, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 21, 2021 •
edited by richardlau
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/36889/ (:heavy_check_mark:)

@richardlau
test: remove references to unsupported AIX versions
cda60c5 
The `filehandle.utimes()` and `fs.futimes()` APIs work on all versions
of AIX that are supported by this version of Node.js.

PR-URL: nodejs#37826
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Stewart X Addison <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
@richardlau
Copy link
Member Author

Landed in cda60c5.

@richardlau richardlau closed this Mar 22, 2021
@richardlau richardlau deleted the housekeeping branch March 22, 2021 10:36
ruyadorno pushed a commit that referenced this pull request Mar 24, 2021
@richardlau @ruyadorno
test: remove references to unsupported AIX versions
9bc6fe7 
The `filehandle.utimes()` and `fs.futimes()` APIs work on all versions
of AIX that are supported by this version of Node.js.

PR-URL: #37826
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Stewart X Addison <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Mar 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AshCripps AshCripps AshCripps approved these changes

@sxa sxa sxa approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
aix Issues and PRs related to the AIX platform. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@richardlau @nodejs-github-bot @Trott @cjihrig @gireeshpunathil @sxa @AshCripps @targos