Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add examples for WHATWG URL objects #37822

Closed
wants to merge 1 commit into from
Closed

doc: add examples for WHATWG URL objects #37822

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Mar 19, 2021

Refs: #25099 (comment)

Signed-off-by: James M Snell [email protected]

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module. labels Mar 19, 2021
MylesBorins
MylesBorins approved these changes Mar 19, 2021
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasnell
Copy link
Member Author

jasnell commented Mar 22, 2021

Landed in 0932e90

@jasnell jasnell closed this Mar 22, 2021
jasnell added a commit that referenced this pull request Mar 22, 2021
@jasnell
doc: add examples for WHATWG URL objects
0932e90 
Signed-off-by: James M Snell <[email protected]>

PR-URL: #37822
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
ruyadorno pushed a commit that referenced this pull request Mar 24, 2021
@jasnell @ruyadorno
doc: add examples for WHATWG URL objects
30bc2e4 
Signed-off-by: James M Snell <[email protected]>

PR-URL: #37822
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Mar 30, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@jasnell @targos
doc: add examples for WHATWG URL objects
7789159 
Signed-off-by: James M Snell <[email protected]>

PR-URL: #37822
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@addaleax addaleax addaleax approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jasnell @MylesBorins @addaleax @RaisinTen @nodejs-github-bot