Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky test-http2-pack-end-stream-flag #37814

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Mar 19, 2021

Signed-off-by: James M Snell [email protected]
Fixes: #37639

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 19, 2021
@jasnell jasnell force-pushed the fix-flaky-test-http2-pack-end-stream-flag branch from c5a0313 to 6e9ccf6 Compare March 19, 2021 14:46
@nodejs-github-bot

This comment has been minimized.

@jasnell jasnell requested review from Trott and targos March 19, 2021 15:07
@nodejs-github-bot

This comment has been minimized.

@jasnell jasnell added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Mar 19, 2021
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 22, 2021

@jasnell
Copy link
Member Author

jasnell commented Mar 22, 2021

Landed in 978bbf9

@jasnell jasnell closed this Mar 22, 2021
jasnell added a commit that referenced this pull request Mar 22, 2021
Signed-off-by: James M Snell <[email protected]>
Fixes: #37639

PR-URL: #37814
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@ruyadorno
Copy link
Member

hi @jasnell I see this changeset doesn't land cleanly on v15.x-staging since it builds on top of #37136 which is a semver-major landing only on v16.x.

With that in mind, should we still backport this fix to v15 ?

@jasnell
Copy link
Member Author

jasnell commented Mar 24, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

investigate flaky test-http2-pack-end-stream-flag
5 participants