Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update gitignore for CMake #37793

Closed
wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

I have using Clion for developing Node.js for a long time. But it's quite annoying I keep the redundant files I don't have to commit. So just ignore them (please free my pain 😃 ).

Currently things look like this:
image

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Mar 18, 2021
@gengjiawen gengjiawen requested a review from targos March 18, 2021 07:05
.gitignore Show resolved Hide resolved
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 19, 2021
@gengjiawen
Copy link
Member Author

Landed in d08ea01

@gengjiawen gengjiawen closed this Mar 20, 2021
@gengjiawen gengjiawen deleted the cmake-ignore branch March 20, 2021 15:02
gengjiawen added a commit that referenced this pull request Mar 20, 2021
PR-URL: #37793
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
ruyadorno pushed a commit that referenced this pull request Mar 24, 2021
PR-URL: #37793
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Mar 30, 2021
targos pushed a commit that referenced this pull request May 1, 2021
PR-URL: #37793
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants