Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v14.x] node-api: define version 8 #37728

Closed
wants to merge 1 commit into from
Closed

[v14.x] node-api: define version 8 #37728

wants to merge 1 commit into from

Conversation

gabrielschulhof
Copy link
Contributor

Mark as stable the APIs that define Node-API version 8.

PR-URL: #37652
Reviewed-By: @Flarna
Reviewed-By: @mhdawson
Reviewed-By: @legendecas

@gabrielschulhof gabrielschulhof added the node-api Issues and PRs related to the Node-API. label Mar 12, 2021
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v14.x labels Mar 12, 2021
@gabrielschulhof gabrielschulhof added semver-minor PRs that contain new features and should be released in the next minor version. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v14.x c++ Issues and PRs that require attention from people who are familiar with C++. and removed c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v14.x labels Mar 12, 2021
mhdawson
mhdawson approved these changes Mar 12, 2021
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabrielschulhof @targos
node-api: define version 8
9b5da4f 
Mark as stable the APIs that define Node-API version 8.

PR-URL: nodejs#37652
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37653/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37672/

targos pushed a commit that referenced this pull request Apr 25, 2021
@gabrielschulhof @targos
node-api: define version 8
36abc18 
Mark as stable the APIs that define Node-API version 8.

PR-URL: #37652
Backport-PR-URL: #37728
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@targos
Copy link
Member

targos commented Apr 25, 2021

Landed in 36abc18

@targos targos closed this Apr 25, 2021
@targos targos mentioned this pull request Apr 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flarna Flarna Flarna approved these changes

@mhdawson mhdawson mhdawson approved these changes

@legendecas legendecas legendecas approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gabrielschulhof @nodejs-github-bot @targos @legendecas @mhdawson @Flarna